svn commit: r469874 - head/x11-fonts/fantasque-sans-mono

[Tobias Kortkamp]

On Mon, May 14, 2018, at 12:24, Raphael Kubo da Costa wrote:
> Author: rakuco
> Date: Mon May 14 10:24:23 2018
> New Revision: 469874
> URL: https://svnweb.freebsd.org/changeset/ports/469874
> 
> Log:
>   Add options to install variants.
>   
>   Fantasque Sans Mono distribution site has variants aside from the standard
>   version. Add options to allow installing those variants.
>   
>   PR:		228206
>   Submitted by:	Jonathan Chen <jonc at chen.org.nz>
> 
> Modified:
>   head/x11-fonts/fantasque-sans-mono/Makefile
>   head/x11-fonts/fantasque-sans-mono/distinfo
> 
> Modified: head/x11-fonts/fantasque-sans-mono/Makefile
> ==============================================================================
> --- head/x11-fonts/fantasque-sans-mono/Makefile	Mon May 14 10:02:38 2018	(r469873)
> +++ head/x11-fonts/fantasque-sans-mono/Makefile	Mon May 14 10:24:23 2018	(r469874)
> @@ -2,9 +2,13 @@
>  
>  PORTNAME=	fantasque-sans-mono
>  PORTVERSION=	1.7.2
> +PORTREVISION=	1
>  CATEGORIES=	x11-fonts
>  MASTER_SITES=	
> https://github.com/belluzj/fantasque-sans/releases/download/v$
> {PORTVERSION}/
> -DISTNAME=	FantasqueSansMono-Normal
> +DISTFILES=	FantasqueSansMono-Normal.tar.gz \
> +		FantasqueSansMono-NoLoopK.tar.gz \
> +		FantasqueSansMono-LargeLineHeight.tar.gz \
> +		FantasqueSansMono-LargeLineHeight-NoLoopK.tar.gz
>  
>  MAINTAINER=	rakuco at FreeBSD.org
>  COMMENT=	Programming font, designed with functionality in mind
> @@ -17,6 +21,21 @@ NO_WRKSUBDIR=	yes
>  USES=		fonts
>  
>  OPTIONS_DEFINE=	DOCS
> +
> +OPTIONS_SINGLE=	VARIANT
> +OPTIONS_SINGLE_VARIANT= NORMAL NOLOOPK LLINE LLINENOLOOPK
> +
> +NORMAL_DESC=	Standard
> +NOLOOPK_DESC=	Nondescript K
> +LLINE_DESC=	Large line spacing
> +LLINENOLOOPK_DESC=	Large line spacing with Nondescript K
> +
> +OPTIONS_DEFAULT=	NORMAL
> +
> +NORMAL_EXTRACT_ONLY=	FantasqueSansMono-Normal.tar.gz
> +NOLOOPK_EXTRACT_ONLY=	FantasqueSansMono-NoLoopK.tar.gz
> +LLINE_EXTRACT_ONLY=	FantasqueSansMono-LargeLineHeight.tar.gz
> +LLINENOLOOPK_EXTRACT_ONLY=	FantasqueSansMono-LargeLineHeight-NoLoopK.tar.gz

Why do I have to download all variants when only one distfile is ever be used for each one?
Why not use something like NORMAL_DISTFILES=FantasqueSansMono-Normal.tar.gz or
NORMAL_VARS=DISTNAME=FantasqueSansMono-Normal instead of the
_EXTRACT_ONLY helpers?