svn commit: r469188 - head/ports-mgmt/pkg_replace

Alexey Dokuchaev danfe at FreeBSD.org
Sun May 6 15:10:59 UTC 2018


On Sun, May 06, 2018 at 08:41:36AM -0600, Adam Weinberger wrote:
> > On 6 May, 2018, at 04:27, Alexey Dokuchaev <danfe at FreeBSD.org> wrote:
> > ...
> > Correct PLIST_FILES should read:
> >
> > PLIST_FILES=	sbin/pkg_replace \
> > 		man/man1/pkg_replace.1.gz \
> > 		@sample\ etc/pkg_replace/pkg_replace.conf.sample
> 
> Sorry, Alexey, but portlint was right here. @sample and other macros
> should *never* appear in PLIST_FILES. Even if the port installs only a
> single file, if it's a @sample, it goes in pkg-plist.

Hmm, that's news to me; I'm pretty sure I've used @sample in PLIST_FILES,
verified generated package, and it came out as expected.  I've also seen
others doing the same.

Admittedly I didn't check this particular example I've written above, but
I don't recall recent changes to the framework that would forbit keywords
from appearing on PLIST_FILES.  I was under impression that LICENSE[_FILE],
PLIST_FILES, PORTDOCS et al. are mixed together prior to keyword expansion.

./danfe


More information about the svn-ports-head mailing list