svn commit: r459751 - in head/lang: . solidity solidity/files

[Alexey Dokuchaev]

On Tue, Jan 23, 2018 at 01:58:22PM +0000, Alex Dupre wrote:
> New Revision: 459751
> URL: https://svnweb.freebsd.org/changeset/ports/459751
> 
> Log:
>   The Solidity Contract-Oriented Programming Language
>   
>   WWW: https://github.com/ethereum/solidity
> 
> Added: head/lang/solidity/Makefile
> ...
> @@ -0,0 +1,34 @@
> +# Created by: Alex Dupre <ale at FreeBSD.org>
> +# $FreeBSD$
> +
> +PORTNAME=	solidity
> +PORTVERSION=	0.4.19
> +CATEGORIES=	lang
> +MASTER_SITES=	https://github.com/ethereum/solidity/releases/download/v${PORTVERSION}/
> +DISTNAME=	${PORTNAME}_${PORTVERSION}
> +
> +MAINTAINER=	ale at FreeBSD.org
> +COMMENT=	Solidity Contract-Oriented Programming Language

COMMENT=	Contract-oriented programming language

> +OPTIONS_DEFINE=	SMT
> +SMT_DESC=	SMT Checker
> +SMT_LIB_DEPENDS=libz3.so:math/z3
> +
> +USES=		cmake

Misplaced USES.

> +CMAKE_ARGS+=	-DUSE_LD_GOLD=OFF -DTESTS=OFF \
> +		-DJSONCPP_INCLUDE_DIR:STRING="${LOCALBASE}/include/jsoncpp" \
> +		-DJSONCPP_LIB_DIR:STRING="${LOCALBASE}/lib"

And CMAKE_ARGS (also bogus +=).

> +pre-patch:
> +		@${CP} ${FILESDIR}/jsoncpp.cmake ${WRKSRC}/cmake/
> +		@${REINPLACE_CMD} '/EthCcache/d' ${WRKSRC}/CMakeLists.txt

Excessive indentation of target recipe (commands).

> Added: head/lang/solidity/pkg-descr
> ...
> @@ -0,0 +1,3 @@
> +The Solidity Contract-Oriented Programming Language
> +
> +WWW: https://github.com/ethereum/solidity

Bad port description (verbatim copy of COMMENT), tells nothing about the
port (violation of PHB Section 3.2.1).

./danfe