svn commit: r461746 - head/security/ca_root_nss

[Mark Felder]

On Wed, Feb 14, 2018, at 07:18, Tijl Coosemans wrote:
> On Tue, 13 Feb 2018 20:45:39 +0000 (UTC) Mark Felder <feld at FreeBSD.org> wrote:
> > Author: feld
> > Date: Tue Feb 13 20:45:38 2018
> > New Revision: 461746
> > URL: https://svnweb.freebsd.org/changeset/ports/461746
> > 
> > Log:
> >   security/ca_root_nss: Add post-exec script to automatically sync to mono's
> >   certificate store
> >   
> >   PR:		225357
> > 
> > Modified:
> >   head/security/ca_root_nss/Makefile
> >   head/security/ca_root_nss/pkg-plist
> > 
> > Modified: head/security/ca_root_nss/Makefile
> > ==============================================================================
> > --- head/security/ca_root_nss/Makefile	Tue Feb 13 20:25:50 2018	(r461745)
> > +++ head/security/ca_root_nss/Makefile	Tue Feb 13 20:45:38 2018	(r461746)
> > @@ -2,6 +2,7 @@
> >  
> >  PORTNAME=	ca_root_nss
> >  PORTVERSION=	${VERSION_NSS}
> > +PORTREVISION=	1
> >  CATEGORIES=	security
> >  MASTER_SITES=	MOZILLA/security/nss/releases/${DISTNAME:tu:C/[-.]/_/g}_RTM/src
> >  DISTNAME=	nss-${VERSION_NSS}${NSS_SUFFIX}
> > 
> > Modified: head/security/ca_root_nss/pkg-plist
> > ==============================================================================
> > --- head/security/ca_root_nss/pkg-plist	Tue Feb 13 20:25:50 2018	(r461745)
> > +++ head/security/ca_root_nss/pkg-plist	Tue Feb 13 20:45:38 2018	(r461746)
> > @@ -3,3 +3,4 @@
> >  @sample openssl/cert.pem.sample
> >  %%ETCSYMLINK%%/etc/ssl/cert.pem
> >  %%ETCSYMLINK%%@dir /etc/ssl
> > + at postexec [ -x %%LOCALBASE%%/bin/cert-sync ] && %%LOCALBASE%%/bin/cert-sync --quiet %%PREFIX%%/share/certs/ca-root-nss.crt
> 
> This command returns an error if the executable doesn't exist.  You
> should invert the logic:
> 
> @postexec [ ! -x %%LOCALBASE%%/bin/cert-sync ] || %%LOCALBASE%%/bin/
> cert-sync --quiet %%PREFIX%%/share/certs/ca-root-nss.crt
> 

What did the error look like? I wasn't seeing anything in my testport runs. I intentionally reversed the logic from the original submitter for readability and now feel like a fool.  :-)

-- 
  Mark Felder
  ports-secteam & portmgr member
  feld at FreeBSD.org