svn commit: r460940 - in head/games: afternoonstalker burgerspace cosmosmash

[Baptiste Daroussin]

On Thu, Feb 08, 2018 at 01:19:31AM -0600, Mark Linimon wrote:
> On Thu, Feb 08, 2018 at 07:13:52AM +0000, Alexey Dokuchaev wrote:
> > On Sun, Feb 04, 2018 at 04:34:17PM +0000, Ganael LAPLANCHE wrote:
> > > New Revision: 460940
> > > URL: https://svnweb.freebsd.org/changeset/ports/460940
> > > 
> > > Log:
> > >   Fix build with Clang 6 (C++14 by default)
> > 
> > ... by forcing gnu++98 without giving the details of the breakages and
> > why they were not properly fixed instead. :-)
> 
> For once I'm going to agree with danfe (someone take a picture!) but only
> to the extent that I would like to ask that the commit messages be "work
> around the build" rather than "fix".  There have been numerous commits that
> did contain actual code fixes.
> 
> Despite the quibble, I appreciate the effort people are putting into the
> clang 6 problems -- these have especially regressed our tier-2 package
> builds.
> 
> mcl
> 
My point here, is variations between c++ standards may make some code incompatible
and sometime the version of the standard may/should be specified, because the
code is clearly C++98.

In clang 6 when you build c++ instead of defaulting of c++98 like it used to be
is now defaulting on c++14 meaning all the code whihch expected c++98 as default
standard are now broken and the -std flag should be supplied. The same happened
when the C compilers switched from C89 to C99 as default standard. On 143 ports
we needed to make that change.

Being compatible with newer c++ standard is an upstream decision to take, not
hours. The compilers are able to specify the standard you are using, imho it is
normal and expected for maintainers to use that feature :)

Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20180208/369c57b1/attachment-0001.sig>