svn commit: r460940 - in head/games: afternoonstalker burgerspace cosmosmash

Alexey Dokuchaev danfe at FreeBSD.org
Thu Feb 8 07:13:53 UTC 2018


On Sun, Feb 04, 2018 at 04:34:17PM +0000, Ganael LAPLANCHE wrote:
> New Revision: 460940
> URL: https://svnweb.freebsd.org/changeset/ports/460940
> 
> Log:
>   Fix build with Clang 6 (C++14 by default)

... by forcing gnu++98 without giving the details of the breakages and
why they were not properly fixed instead. :-)

I appreciate fixing the build, but USE_CXXSTD should be used only if
proper fix would be hard, or the patch would be way too long.  Clang 6
might be too pedantic, but it often reveals real bugs in the code, so
it's better not simply suppress them with USE_CXXSTD.  At least give
some details so interested committer could come by and attempt to find
a better fix.  Thanks,

./danfe


More information about the svn-ports-head mailing list