svn commit: r478608 - head/devel/msgpack

[Adam Weinberger]

On Fri, Aug 31, 2018 at 2:15 PM Jan Beich <jbeich at freebsd.org> wrote:
>
> Author: jbeich
> Date: Fri Aug 31 20:14:57 2018
> New Revision: 478608
> URL: https://svnweb.freebsd.org/changeset/ports/478608
>
> Log:
>   devel/msgpack: restore TEST_TARGET after r470984
>
>   TEST_DEPENDS is pointless without do-test or TEST_TARGET. automake
>   required googletest only during "check" but cmake wants it upfront
>   during "test". So, move tests into a separate option.

I don't get it. 130 ports out of 33,012 have TEST options. That's
0.3%. This sounds like your personal preference, not an "any
maintainer would want this fixed" commit. OPTIONS are to let users
customize the package, not to assist people who want to run their own
regression tests.

The fact that poudriere doesn't automatically run tests is not
justification to adding a non-standard OPTION. If you want to test it
in poudriere, run testport -i and run ctest yourself.

Please back this out.

# Adam


-- 
Adam Weinberger
adamw at adamw.org
https://www.adamw.org