svn commit: r477306 - in head: audio audio/pulseaudio-module-xrdp net/xrdp

[Mathieu Arnold]

On Thu, Aug 16, 2018 at 01:51:04AM +0000, Koichiro Iwao wrote:
> +PORTNAME=	pulseaudio-module-xrdp
> +PORTVERSION=	0.0.20180808

This is not the way to handle software that do not define versions.
Please read this to learn how to handle this in the future:

https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex4

> +CATEGORIES=	audio
> +
> +MAINTAINER=	meta at FreeBSD.org
> +COMMENT=	PulseAudio module which enables xrdp to use audio redirection
> +
> +LICENSE=	APACHE20
> +
> +BUILD_DEPENDS=	${NONEXISTENT}:audio/pulseaudio:configure \
> +		${LOCALBASE}/include/xrdp_constants.h:net/xrdp
> +LIB_DEPENDS=	libpulse.so:audio/pulseaudio
> +
> +USES=		autoreconf:build libtool pkgconfig
> +GNU_CONFIGURE=	yes
> +USE_GITHUB=	yes
> +GH_ACCOUNT=	neutrinolabs
> +GH_PROJECT=	pulseaudio-module-xrdp

Default, remove.

> +GH_TAGNAME=	0d80384
> +
> +PLIST_FILES=	`${PULSE_MODDIR}`/module-xrdp-sink.so \
> +		`${PULSE_MODDIR}`/module-xrdp-source.so

The ` seem very strange here and only work because of the current
implementation details of PLIST_FILES.  Please find another way to
handle this.


-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20180816/e6310cea/attachment.sig>