svn commit: r468186 - head/databases/sfcgal

[Mathieu Arnold]

On Tue, Apr 24, 2018 at 07:28:36AM +0000, Yuri Victorovich wrote:
> +
> +PLIST_SUB=	SHL3=${PORTVERSION} SHL1=${PORTVERSION:R:R}

While your SHL3 replacements are something that is somewhat ok, though
unnecessary with make makeplist, the SHL1 is a very bad idea.

Because when the major version changes, it will get automagically
changed in the plist, and the maintainer will not think about bumping
all dependent ports.

Whereas if the plist needs updating, it shows the major shlib version
update, and it is harder to miss.

>  lib/libSFCGAL.so
> -lib/libSFCGAL.so.1
> -lib/libSFCGAL.so.1.3.2
> +lib/libSFCGAL.so.%%SHL1%%
> +lib/libSFCGAL.so.%%SHL3%%

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20180424/86aea2fa/attachment.sig>