svn commit: r455053 - in head/devel/gitaly: . files

Alexey Dokuchaev danfe at FreeBSD.org
Tue Nov 28 16:44:46 UTC 2017


On Tue, Nov 28, 2017 at 05:19:53PM +0100, Torsten Zuehlsdorff wrote:
> On 28.11.2017 17:10, Alexey Dokuchaev wrote:
> > On Tue, Nov 28, 2017 at 04:06:22PM +0000, Torsten Zuehlsdorff wrote:
> >> New Revision: 455053
> >> URL: https://svnweb.freebsd.org/changeset/ports/455053
> >>
> >> Log:
> >>    devel/gitaly: Update config example
> >>    
> >>    Add more sections for referenced software using
> >>    there correct paths.
> >>    
> >>    Submitted by: Matthias Fechner <idefix at fechner.net>
> >> [...]
> >> @@ -1,5 +1,5 @@
> >> ---- config.toml.example.orig	2017-09-01 10:24:38 UTC
> >> -+++ config.toml.example
> >> +--- config.toml.example.orig	2017-10-28 10:50:48.245547000 +0200
> >> ++++ config.toml.example	2017-10-28 10:56:00.467310000 +0200
> > 
> > Could you please try to retain original (correct) timestamps in the
> > patches?  It's too late now, but ``make makepatch'' would be a nice
> > thing to add to your repertoire in the future.  Thanks,
> 
> As you may noticed the patch isn't from me.

It's part of our job as committers to fix shortcomings of submitted
patches.

> Maybe i should have enforced it, but i didn't see any benefit in
> another round.

It helps to recude repochurn and makes cleaner diffs.  That's why it
(makepatch) was put together in the first place.

./danfe


More information about the svn-ports-head mailing list