svn commit: r435996 - in head: . security security/samhain security/samhain-client security/samhain-server security/samhain/files

[Mathieu Arnold]

Le 12/03/2017 à 18:07, Nikolai Lifanov a écrit :
> +CONFIGURE_ARGS=	--localstatedir=/var \

You can drop that, it is already added by default by the
_LATE_CONFIGURE_ARGS mechanism.

> +GNUPG_BUILD_DEPENDS=		gpg:${PORTSDIR}/security/gnupg

We dropped adding PORTSDIR to the depends line about a year ago, please
do not add more.

> +PRELUDE_LIB_DEPENDS=		prelude:${PORTSDIR}/security/libprelude

Same here.

> +pre-everything::
> +
> +.if !defined(WITH_CLIENT) && !defined(WITH_SERVER)
> +	@${ECHO_MSG}
> +	@${ECHO_MSG} "Building Samhain in standalone mode."
> +	@${ECHO_MSG} "If you wish to enable networked mode, please hit CTRL-C"
> +	@${ECHO_MSG} "now, and build samhain from the samhain-client and"
> +	@${ECHO_MSG} "samhain-server ports."
> +	@${ECHO_MSG}
> +.endif
> +
> +.if defined(WITH_CLIENT) && defined(WITH_SERVER)
> +IGNORE=		can't build client and server at once
> +.endif
> +
> +.if ${PORT_OPTIONS:MKCHECK}
> +	@${ECHO_MSG}
> +	@${ECHO_MSG} "Building with kernel checking requires reading /dev/kmem"
> +	@${ECHO_MSG} "and /dev/mem. If you're not building as root, please hit"
> +	@${ECHO_MSG} "Control-C and restart the build as root."
> +	@${ECHO_MSG}
> +.endif

You should not put some other code right in the middle of a target, so
you should move the IGNORE after it.
> +post-install:
>
> +post-stage:
>

Don't use both post-install and post-stage, only use post-install.

-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20170314/1c54c041/attachment.sig>