svn commit: r443975 - in head: games/aquaria multimedia/libmediainfo sysutils/fusefs-encfs textproc/tinyxml2
Jan Beich
jbeich at FreeBSD.org
Mon Jun 26 11:16:23 UTC 2017
Jan Beich <jbeich at FreeBSD.org> writes:
> Sunpoet Po-Chuan Hsieh <sunpoet at FreeBSD.org> writes:
>
>> Author: sunpoet
>> Date: Tue Jun 20 13:59:08 2017
>> New Revision: 443975
>> URL: https://svnweb.freebsd.org/changeset/ports/443975
>>
>> Log:
>> Update textproc/tinyxml2 to 5.0.0
>>
>> - Use PLIST instead of PLIST_FILES
>> - Bump PORTREVISION for shlib change
>>
>> Changes: https://github.com/leethomason/tinyxml2/commits/master
>>
>> Added:
>> head/textproc/tinyxml2/pkg-plist (contents, props changed)
>> Modified:
>> head/games/aquaria/Makefile
>> head/multimedia/libmediainfo/Makefile
>> head/sysutils/fusefs-encfs/Makefile
>> head/textproc/tinyxml2/Makefile
>> head/textproc/tinyxml2/distinfo
>
> At least games/aquaria is now broken:
>
> CMakeFiles/aquaria.dir/Aquaria/Continuity.cpp.o: In function
> `Continuity::loadFileData(int, tinyxml2::XMLDocument&)':
> /wrkdirs/usr/ports/games/aquaria/work/Aquaria-OSE-v1.002-22-g84366ad/Aquaria/Continuity.cpp:(.text+0x156ef):
> undefined reference to `tinyxml2::StrPair::GetStr()'
> CMakeFiles/aquaria.dir/Aquaria/DSQ.cpp.o: In function
> `DSQ::loadModsCallback(std::__1::basic_string<char,
> std::__1::char_traits<char>, std::__1::allocator<char> > const&,
> int)':
> /wrkdirs/usr/ports/games/aquaria/work/Aquaria-OSE-v1.002-22-g84366ad/Aquaria/DSQ.cpp:(.text+0xe01d):
> undefined reference to `tinyxml2::StrPair::GetStr()'
> c++: error: linker command failed with exit code 1 (use -v to see invocation)
> *** Error code 1
>
> https://lists.freebsd.org/pipermail/freebsd-pkg-fallout/Week-of-Mon-20170619/490103.html
I've fixed this. Next time, please, properly test consumers, not just
blindly bump PORTREVISION.
AquariaOSE upstream believes the regression is in TinyXML2. Some symbols
(e.g., StrPair::GetStr) disappeared in 5.0.0 despite *still* being part
of the public API. XMLDocument::GetErrorStr1() is no longer usable which
also broke other consumers (not in ports).
https://github.com/leethomason/tinyxml2/issues/498
https://github.com/KAPSARC/KTAB/commit/120dba9fb7a7
More information about the svn-ports-head
mailing list