svn commit: r430355 - in head/lang: erlang erlang-runtime19

[Matthew Seaman]

On 02/01/2017 13:24, Jimmy Olgeni wrote:
> +.if !exists(/usr/sbin/dtrace)
> +OPTIONS_EXCLUDE+=	DTRACE
> +.endif
> +
> +OPTIONS_EXCLUDE_FreeBSD_9=	DTRACE
> +OPTIONS_EXCLUDE_FreeBSD_10=	DTRACE
> +OPTIONS_EXCLUDE_i386=		DTRACE
> +

I am not sure that the way you have enabled DTRACE by default makes much
sense.  I investigated building ports via poudriere with DTRACE enabled
a little while back and I found

  * poudriere jails need a copy of the host systems' kernel -- never
    mind if that is a different OS version than what the jail is using.

  * It's impossible to build successfully with enabled DTRACE when
    crossbulding for i386 on a host system running amd64.

I've a pull request here: https://github.com/freebsd/poudriere/pull/410
to add a capability to null-mount the host system kernel into poudriere
jails which allows building with DTRACE enabled for 9 and 10 on an 11 host.

However, I suspect that most of these problems are artifacts of the way
poudriere uses jails to build for the various OS versions etc.  Building
/natively/ on any of the combinations of OS and architecture might very
well work.

My recommendation would be to either leave DTRACE support present for
all OS/arch combinations, but disabled by default. Or to automatically
disable DTRACE if building under poudriere can be detected.  Which means
unfortunately that precompiled pkgs wouldn't have DTRACE support enabled.

	Cheers,

	Matthew



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 931 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20170102/832c6765/attachment.sig>