svn commit: r448998 - head/net-mgmt/tcpreplay

[Dan Langille]

> On Aug 30, 2017, at 3:54 PM, Mathieu Arnold <mat at FreeBSD.org> wrote:
> 
> Le 30/08/2017 à 21:47, Emanuel Haupt a écrit :
>> 
>> 
>> On 30.08.17 21:32, Dan Langille wrote:
>>> Author: dvl
>>> Date: Wed Aug 30 19:32:00 2017
>>> New Revision: 448998
>>> URL: https://svnweb.freebsd.org/changeset/ports/448998
>>> 
>>> Log:
>>>    Add base/port options for libpcap
>>>       PR:        221923
>>>    Approved by:    ehaupt (maintainer)
>>> 
>>> Modified:
>>>    head/net-mgmt/tcpreplay/Makefile
>>> 
>>> Modified: head/net-mgmt/tcpreplay/Makefile
>>> ==============================================================================
>>> 
>>> --- head/net-mgmt/tcpreplay/Makefile    Wed Aug 30 19:18:00 2017   
>>> (r448997)
>>> +++ head/net-mgmt/tcpreplay/Makefile    Wed Aug 30 19:32:00 2017   
>>> (r448998)
>>> @@ -4,6 +4,7 @@
>>>   PORTNAME=    tcpreplay
>>>   PORTVERSION=    4.2.6
>>>   DISTVERSIONPREFIX=    v
>>> +PORTREVISION=    1
>>>   CATEGORIES=    net-mgmt
>>>     MAINTAINER=    ehaupt at FreeBSD.org
>>> @@ -26,6 +27,18 @@ CONFIGURE_ARGS=   
>>> --program-transform-name='s|.*\(tcp.*\
>>>     # required when using autogen
>>>   CONFIGURE_ARGS+=    --disable-local-libopts --disable-libopts-install
>>> +
>>> +OPTIONS_DEFINE=    LIBPCAP_BASE LIBPCAP_PORTS
>>> +LIBPCAP_BASE=    Build with libpcap from the base OS
>>> +LIBPCAP_PORTS=    Build with net/libpcap
>>> +
>>> +OPTIONS_SINGLE=    SG1
>>> +OPTIONS_SINGLE=    LIBPCAP_BASE LIBPCAP_PORTS
>>> +
>>> +OPTIONS_DEFAULT=    LIBPCAP_BASE
>>> +
>>> +LIBPCAP_PORTS_BUILD_DEPENDS=    ${LOCALBASE}/lib/libpcap.a:net/libpcap
>>> +LIBPCAP_PORTS_LIB_DEPENDS=    libpcap.so:net/libpcap
>>>     post-patch:
>>>       @${REINPLACE_CMD} -e 's|-Wall -O3||'
>>> ${WRKSRC}/${CONFIGURE_SCRIPT}.ac
>>> 
>> 
>> Are you going to add a description for LIBPCAP_BASE and LIBPCAP_PORTS
>> in ports/Mk/bsd.options.desc.mk? Right now the two options have no
>> description.
> 
> I think it would be faster to add _DESC for the options descriptions here.


I see the descriptions in there, but they are not correctly set.  I will fix this now.

-- 
Dan Langille - BSDCan / PGCon
dan at langille.org