svn commit: r448928 - in head/graphics: . drm-next-kmod

[Jan Beich]

Johannes M Dieterich <jmd at freebsd.org> writes:

> Jung-uk Kim – Tue., 29. August 2017 16:46
>> On 08/29/2017 13:13, Jan Beich wrote:
>> > Johannes M Dieterich <jmd at FreeBSD.org> writes:
>> > 
>> >> Author: jmd
>> >> Date: Tue Aug 29 16:32:19 2017
>> >> New Revision: 448928
>> >> URL: svnweb.freebsd.org/changeset/ports/448928
>> >>
>> >> Log:
>> >>   New port: graphics/drm-next-kmod.
>> > [...]
>> >> +USES=		kmod uidfix
>> > 
>> > Fails to build if SRC_BASE != /usr/src. With SRCTOP undefined the port
>> > relies on /sys symlink existing and pointing to a real location. The
>> > latter conflicts with $SRC_BASE/etc/Makefile hardcoding "usr/src/sys".
>> > 
>> > Maybe add MAKE_ENV = SRCTOP="${SRC_BASE}" to fix the following.
>> > 
>> > $ make DISABLE_MAKE_JOBS=
>> > ===>  Building for drm-next-kmod-g20170825
>> > ===> drm (all)
>> > Warning: Object directory not changed from original /usr/ports/graphics/drm-next-kmod/work/kms-drm-4ee5acb/drm
>> > ===> amd (all)
>> > make[3]:
>> > "/usr/ports/graphics/drm-next-kmod/work/kms-drm-4ee5acb/amd/Makefile"
>> > line 3: Cannot open /sys/conf/kern.opts.mk
>> > make[3]: Fatal errors encountered -- cannot continue
>> > make[3]: stopped in /usr/ports/graphics/drm-next-kmod/work/kms-drm-4ee5acb/amd
>> > *** Error code 1
>
> ... my understanding is that for kmods we require /usr/src?

Custom base system source location when building kernel modules has been
supported for a long time, probably as long as non-root builds. Before
SRC_BASE existed such ports usually relied on SYSDIR directly which
is defined by bsd.kmod.mk.

> I checked with kwm and he pointed out that people not
> running /non-usr/src systems should set SRC_BASE properly in their
> Mk/Uses/kmod.mk (I haven't tested this).

I have both SRC_BASE and SYSDIR defined via environment. No issues with
other -kmod ports for >5 years.

Did you miss that this port doesn't respect SRC_BASE at all?