svn commit: r423434 - head/security/openssl

[Mathieu Arnold]

Le 07/10/2016 à 08:38, Bernard Spil a écrit :
> On 2016-10-07 5:36, Joseph Mingrone wrote:
>> Mathieu Arnold <mat at FreeBSD.org> writes:
>>
>>> Le 06/10/2016 à 21:38, Bernard Spil a écrit :
>>>> Author: brnrd
>>>> Date: Thu Oct  6 19:38:48 2016
>>>> New Revision: 423434
>>>> URL: https://svnweb.freebsd.org/changeset/ports/423434
>>
>>>> Log:
>>>>   security/openssl: Fix ldconfig issue
>>
>>>>     - OPT_USE= feature does not behave as expected
>>
>>> I strongly disagree with that comment, the opt_USE works exactly as
>>> expected, and as documented.
>>
>> If I am understanding the documentation correctly
>>
>> OPT_USE=    ldconfig=${PREFIX}/lib/blah/lib
>>
>> should add ${PREFIX}/lib/blah/lib to ${LOCALBASE}/libdata/ldconfig/blah.
>>
>> I just tested and it is not creating
>> ${LOCALBASE}/libdata/ldconfig/blah when OPT is on.
>>
>> The code below does.
>>
>> .if ${PORT_OPTIONS:MOPT}
>> USE_LDCONFIG=    ${PREFIX}/lib/blah/lib
>> .endif
>
> Hi Joseph,
>
> That's another issue which is specific to using ${PREFIX} at this stage.
> When I set
> SHARED_USE=             ldconfig=${PREFIX}/lib/blah
>
> $ make -VUSE_LDCONFIG
> /lib/blah
> as ${PREFIX} isn't set during options processing

Try the patch in https://reviews.freebsd.org/D8169.

> I was just looking for the default behavior here. Setting SHARED_USE=
> ldconfig results in
> $ make -VUSE_LDCONFIG
> ldconfig
>
> for lack of an `=' character in the SHARED_USE value. I have created
> D8166 that simply sets USE_FEATURE= yes when no `=' is present in
> OPT_USE= feature.

I don't really like that, it should be either an error, or be ignored,
there are not a lot of USE_ where a yes value makes sense.

-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20161007/899af557/attachment.sig>