svn commit: r416053 - head/Mk/Uses
Alexey Dokuchaev
danfe at FreeBSD.org
Sun May 29 15:29:49 UTC 2016
On Sat, May 28, 2016 at 10:02:55PM +0200, Kurt Jaeger wrote:
> > [...]
> > I should explain a bit more.
> >
> > This goes against the Right Way Of Doing Things(c)(r)(tm).
> >
> > To add a target to be run in the targets pipeline, you use _USES_xxx, you
> > never, ever, piggyback on an existing target, especially if you're not
> > using it.
> >
> > So, please, back this out.
>
> Done. I'm not sure *why* the kde folks requested this change
> in the first place, so I'll ask them.
In this case I'm even more puzzled: why commit a change that you don't fully
understand? You should've asked them before committing, not after.
Writing proper commit messages also helps: lack of "why" clause (or inability
to come up with one) indicates that change is probably not committable yet.
./danfe
More information about the svn-ports-head
mailing list