svn commit: r411417 - in head/multimedia: . libdcadec

[Jan Beich]

(Simple ports tend to have more style issues, paradoxically)

Thomas Zander <riggs at FreeBSD.org> writes:

> +GH_TAGNAME=	v${PORTVERSION}

Convert to DISTVERSIONPREFIX and re-run |make makesum|. It should
remove version duplication from distinfo.

> +NO_CONFIGURE=	yes

Why? bsd.port.mk explicitly says there's no such variable.

> +USES=		pkgconfig gmake

Maybe sort.

> +LDFLAGS+=	-lm

Maybe use LIBS to undo MAKE_ENV damage.

> +		-e 's;$$(LIBDIR)/pkgconfig;$$(PREFIX)/libdata/pkgconfig;' \

Maybe convert to

  USES=		... pathfix
  PATHFIX_MAKEFILEIN=	Makefile

>	${REINPLACE_CMD} -e 's;INCLUDEDIR;MYINCLUDEDIR;g' \
>		-e 's;LIBDIR;MYLIBDIR;g' \
>		${WRKSRC}/dcadec.pc.in \
>		${WRKSRC}/Makefile

MAKE_ARGS would be shorter.

Index: multimedia/libdcadec/Makefile
===================================================================
--- multimedia/libdcadec/Makefile	(revision 411417)
+++ multimedia/libdcadec/Makefile	(working copy)
@@ -2,6 +2,7 @@
 
 PORTNAME=	libdcadec
 PORTVERSION=	0.2.0
+DISTVERSIONPREFIX=	v
 CATEGORIES=	multimedia
 
 MAINTAINER=	mickael.maillot at gmail.com
@@ -12,22 +13,15 @@ LICENSE=	LGPL21
 USE_GITHUB=	yes
 GH_ACCOUNT=	foo86
 GH_PROJECT=	dcadec
-GH_TAGNAME=	v${PORTVERSION}
 
-NO_CONFIGURE=	yes
-USES=		pkgconfig gmake
-LDFLAGS+=	-lm
+USES=		gmake pathfix pkgconfig
+PATHFIX_MAKEFILEIN=	Makefile
 MAKE_ENV+=	CONFIG_SHARED=yes
+MAKE_ARGS+=	INCLUDEDIR="${PREFIX}/include" LIBDIR="${PREFIX}/lib"
+LIBS+=		-lm
 
 USE_LDCONFIG=	yes
 
-post-patch:
-	${REINPLACE_CMD} -e 's;INCLUDEDIR;MYINCLUDEDIR;g' \
-		-e 's;$$(LIBDIR)/pkgconfig;$$(PREFIX)/libdata/pkgconfig;' \
-		-e 's;LIBDIR;MYLIBDIR;g' \
-		${WRKSRC}/dcadec.pc.in \
-		${WRKSRC}/Makefile
-
 post-install:
 	${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/dcadec
 	${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/${PORTNAME}.so.0.1.0
Index: multimedia/libdcadec/distinfo
===================================================================
--- multimedia/libdcadec/distinfo	(revision 411417)
+++ multimedia/libdcadec/distinfo	(working copy)
@@ -1,2 +1,2 @@
-SHA256 (foo86-dcadec-0.2.0-v0.2.0_GH0.tar.gz) = ed9d207fde3e8d576f3af8b0d1235b3371e315175757173689104efcaebf0d44
-SIZE (foo86-dcadec-0.2.0-v0.2.0_GH0.tar.gz) = 225305
+SHA256 (foo86-dcadec-v0.2.0_GH0.tar.gz) = ed9d207fde3e8d576f3af8b0d1235b3371e315175757173689104efcaebf0d44
+SIZE (foo86-dcadec-v0.2.0_GH0.tar.gz) = 225305
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 602 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20160319/3b078ea7/attachment.sig>