svn commit: r396547 - in head/textproc: . smi

[Jason Unovitch]

On Wed, Sep 09, 2015 at 10:06:07PM -0400, Philip M. Gollucci wrote:
> Well gosh.  I must not approve things while crszy.
> 
> Thanks Jan!

Seconded! Thanks Jan.
> 
> On Wednesday, September 9, 2015, Jan Beich <jbeich at freebsd.org> wrote:
> 
> > Jason Unovitch <junovitch at FreeBSD.org> writes:
> >
> > > +post-patch:
> > > +     ${REINPLACE_CMD} -e 's|^CC = .*|CC = ${CC}|' \
> >
> > CC is defined by default to a sane value in both GNU and BSD make.
> > One can do '/^CC/d' but see below for better way.

The intent was to catch the hard coded CC = cc in the port's config.mk.
This port doesn't seem to respect getting CC passed by MAKE_ENV.
> >
> > > +                      -e 's|^PREFIX = .*|PREFlX = ${PREFIX}|' \
> >                                                ^^^
> > Typo: l .vs I. It still works because PREFIX is also passed via MAKE_ENV.

I'm not sure how I managed to miss that one.
> >
> > > +                      -e 's|^MANPREFIX = .*|MANPREFIX = ${MANPREFIX}|' \
> > > +                      ${WRKSRC}/config.mk
> >
> > If possible try to avoid patching makefiles if overriding a few
> > variables is enough. For one, your entire post-patch can be:
> >
> >   MAKE_ARGS=    CC="${CC}" PREFIX="${PREFIX}" MANPREFIX="${MANPREFIX}"
> >
> 

Working on the corrections now. Thanks again!