svn commit: r394508 - in head: . Mk Tools/scripts audio/amarok-kde4 audio/jack audio/lua51-mpd audio/py-mpd2 biology/ruby-bio chinese/joe chinese/phpbb3-tw databases/jdbm2 databases/luasql-mysql da...
Bryan Drewery
bdrewery at FreeBSD.org
Fri Sep 4 17:06:52 UTC 2015
On 9/4/2015 2:36 AM, Baptiste Daroussin wrote:
> On Thu, Sep 03, 2015 at 04:54:48PM -0700, Bryan Drewery wrote:
>> On 8/17/15 7:20 AM, Mathieu Arnold wrote:
>>> Author: mat
>>> Date: Mon Aug 17 14:20:40 2015
>>> New Revision: 394508
>>> URL: https://svnweb.freebsd.org/changeset/ports/394508
>>>
>>> Log:
>>> Remove UNIQUENAME and LATEST_LINK.
>>>
>>> UNIQUENAME was never unique, it was only used by USE_LDCONFIG and now,
>>> we won't have conflicts there.
>>>
>>> Use PKGBASE instead of LATEST_LINK in PKGLATESTFILE, the *only* consumer
>>> is pkg-devel, and it works just fine without LATEST_LINK as pkg-devel
>>> has the correct PKGNAME anyway.
>>>
>>> Now that UNIQUENAME is gone, OPTIONSFILE is too. (it's been called
>>> OPTIONS_FILE now.)
>>
>> Please restore handling for OPTIONSFILE. It was there for backwards
>> compat and now breaks POLA.
>>
>> I had options in a OPTIONSFILE that unset things that now are coming back.
>>
>> For example I have a /var/db/ports/gpgme/options that had
>> OPTIONS_UNSET+= UISERVER, but I have no
>> /var/db/ports/security_gpgme/options. So now I get the defaults.
>>
> This is weird because the ports tree should have automatically moved those to
> security_gpgme during the last years
Clearly it does not. It seems to have only been when running 'config'
etc. It did not convert when building a port. As someone who hasn't
visited 'config' in years, I have a ton of unconverted data:
total 790
drwxr-xr-x 569 root wheel 569 Jun 1 08:16 ./
drwxr-xr-x 9 root wheel 24 Aug 18 12:52 ../
drwxr-xr-x 2 root wheel 3 Jun 19 2012 MySQLdb/
drwxr-xr-x 2 root wheel 3 Jun 24 2012 aolserver/
drwxr-xr-x 2 root wheel 3 Sep 2 2012 apache22/
drwxr-xr-x 2 root wheel 3 Sep 2 2012 apache22-worker-mpm/
drwxr-xr-x 2 root wheel 3 Aug 26 2012 arj/
drwxr-xr-x 2 root wheel 3 May 3 2013 aspell/
drwxr-xr-x 2 root wheel 3 Sep 1 2012 avahi/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 binutils/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 boost-python-libs/
drwxr-xr-x 2 root wheel 3 Oct 26 2012 bsdinfo/
drwxr-xr-x 2 root wheel 3 Jul 25 2012 c-ares/
drwxr-xr-x 2 root wheel 3 Oct 20 2012 cairo/
drwxr-xr-x 2 root wheel 3 Oct 20 2012 cclient/
drwxr-xr-x 2 root wheel 3 Jul 25 2012 clang/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 coreutils/
drwxr-xr-x 2 root wheel 3 Feb 1 2013 cracklib/
drwxr-xr-x 2 root wheel 3 Dec 10 2012 cronolog/
drwxr-xr-x 2 root wheel 3 Dec 10 2012 cscope/
drwxr-xr-x 2 root wheel 3 Jan 26 2013 cyrus-sasl2/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 daemontools/
drwxr-xr-x 2 root wheel 3 Jun 28 2012 dcc-dccd/
drwxr-xr-x 2 root wheel 3 Feb 1 2013 dejavu/
drwxr-xr-x 2 root wheel 3 Aug 30 2012 docbook/
drwxr-xr-x 2 root wheel 3 Aug 30 2012 docbook-500/
drwxr-xr-x 2 root wheel 3 Aug 30 2012 docbook-xsl/
drwxr-xr-x 2 root wheel 3 Jun 27 2013 dovecot-pigeonhole/
drwxr-xr-x 2 root wheel 3 Feb 13 2013 dovecot2/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 eaccelerator/
drwxr-xr-x 2 root wheel 3 May 3 2013 enchant/
drwxr-xr-x 2 root wheel 3 Nov 7 2012 expect/
drwxr-xr-x 2 root wheel 3 Jun 24 2012 ezmlm-idx/
drwxr-xr-x 2 root wheel 3 Aug 26 2012 fossil/
drwxr-xr-x 2 root wheel 3 Oct 20 2012 fping/
drwxr-xr-x 2 root wheel 3 Oct 20 2012 freeipmi/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 gamin/
drwxr-xr-x 2 root wheel 3 May 3 2013 gconf2/
drwxr-xr-x 2 root wheel 3 Jun 24 2012 gd/
drwxr-xr-x 2 root wheel 3 Oct 20 2012 gdk-pixbuf2/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 git/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 glib20/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 gmp/
drwxr-xr-x 2 root wheel 3 May 22 2013 gpgme/
drwxr-xr-x 2 root wheel 3 Jun 22 2012 graphviz/
drwxr-xr-x 2 root wheel 3 Oct 20 2012 gtk20/
drwxr-xr-x 2 root wheel 3 Jul 25 2012 help2man/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 icu/
drwxr-xr-x 2 root wheel 3 Oct 19 2012 iperf/
drwxr-xr-x 2 root wheel 3 Oct 19 2012 ipmitool/
drwxr-xr-x 2 root wheel 3 Oct 20 2012 istgt/
drwxr-xr-x 2 root wheel 3 Dec 10 2012 keychain/
drwxr-xr-x 2 root wheel 3 Aug 30 2012 libcheck/
drwxr-xr-x 2 root wheel 3 Oct 20 2012 libevent2/
drwxr-xr-x 2 root wheel 3 Feb 1 2013 libffi/
drwxr-xr-x 2 root wheel 3 Oct 20 2012 libslang2/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 libssh2/
drwxr-xr-x 2 root wheel 3 Apr 29 2013 libxml2/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 libxslt/
drwxr-xr-x 2 root wheel 3 Jun 24 2012 lighttpd/
drwxr-xr-x 2 root wheel 3 Feb 1 2013 mbuffer/
drwxr-xr-x 2 root wheel 3 Jun 24 2012 nagios/
drwxr-xr-x 2 root wheel 3 Jul 27 2012 neon29/
drwxr-xr-x 2 root wheel 3 Sep 1 2012 netatalk/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 nrpe2/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 oidentd/
drwxr-xr-x 2 root wheel 3 Feb 1 2013 openjdk6/
drwxr-xr-x 2 root wheel 3 Jun 24 2012 p5-Authen-SASL/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 p5-Class-C3/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 p5-Config-Auto/
drwxr-xr-x 2 root wheel 3 Feb 1 2013 p5-Curses/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 p5-DBD-mysql/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 p5-DBI/
drwxr-xr-x 2 root wheel 3 Jul 25 2012 p5-DateTime/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 p5-IO-Socket-SSL/
drwxr-xr-x 2 root wheel 3 Jul 1 2012 p5-Mail-SpamAssassin/
drwxr-xr-x 2 root wheel 3 May 1 2013 p5-Net-SSLeay/
drwxr-xr-x 2 root wheel 3 Jun 24 2012 p5-Net-Server/
drwxr-xr-x 2 root wheel 3 Dec 10 2012 p5-Path-Class/
drwxr-xr-x 2 root wheel 3 Aug 26 2012 p5-XML-SAX/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 p5-libwww/
drwxr-xr-x 2 root wheel 3 May 1 2013 pango/
drwxr-xr-x 2 root wheel 3 Aug 27 2012 parallel/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 pecl-APC/
drwxr-xr-x 2 root wheel 3 Sep 27 2012 php5-extensions/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 php5-gd/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 php5-mbstring/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 php5-mysql/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 php5-mysqli/
drwxr-xr-x 2 root wheel 3 Apr 29 2013 php52/
drwxr-xr-x 2 root wheel 3 Sep 27 2012 php53-extensions/
drwxr-xr-x 2 root wheel 3 Oct 20 2012 php53-gd/
drwxr-xr-x 2 root wheel 3 Oct 20 2012 php53-imap/
drwxr-xr-x 2 root wheel 3 Oct 20 2012 php53-mbstring/
drwxr-xr-x 2 root wheel 3 Oct 20 2012 php53-mysql/
drwxr-xr-x 2 root wheel 3 Oct 20 2012 php53-mysqli/
drwxr-xr-x 2 root wheel 3 Oct 20 2012 php53-sqlite/
drwxr-xr-x 2 root wheel 3 Oct 20 2012 pixman/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 pl-ekg/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 pl-libgadu/
drwxr-xr-x 2 root wheel 3 May 3 2013 polkit/
drwxr-xr-x 2 root wheel 3 Oct 15 2012 portmaster/
drwxr-xr-x 2 root wheel 3 Jun 24 2012 portshaker/
drwxr-xr-x 2 root wheel 3 Aug 3 2012 portupgrade/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 postgresql90/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 pth/
drwxr-xr-x 2 root wheel 3 Oct 20 2012 py-Jinja2/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 py-twisted/
drwxr-xr-x 2 root wheel 3 Oct 20 2012 qmail/
drwxr-xr-x 2 root wheel 3 Jul 24 2012 qmail-tls/
drwxr-xr-x 2 root wheel 3 Aug 26 2012 qmhandle/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 rkhunter/
drwxr-xr-x 2 root wheel 3 Jul 25 2012 rubygem-net-ssh/
drwxr-xr-x 2 root wheel 3 Jul 25 2012 rubygem-passenger/
drwxr-xr-x 2 root wheel 3 Sep 1 2012 samba36/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 screen/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 silc/
drwxr-xr-x 2 root wheel 3 Jun 25 2012 simscan/
drwxr-xr-x 2 root wheel 3 Jan 3 2013 sleuthkit/
drwxr-xr-x 2 root wheel 3 Feb 1 2013 t1lib/
drwxr-xr-x 2 root wheel 3 Sep 1 2012 talloc/
drwxr-xr-x 2 root wheel 3 Aug 26 2012 tarsnap/
drwxr-xr-x 2 root wheel 3 Feb 1 2013 tcl82/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 tcl83/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 tcl84/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 tcl85/
drwxr-xr-x 2 root wheel 3 Feb 11 2013 tcl86/
drwxr-xr-x 2 root wheel 3 Sep 1 2012 tdb/
drwxr-xr-x 2 root wheel 3 Dec 10 2012 tintin++/
drwxr-xr-x 2 root wheel 3 Nov 7 2012 tk84/
drwxr-xr-x 2 root wheel 3 May 1 2013 tk85/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 ucspi-tcp/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 unrar/
drwxr-xr-x 2 root wheel 3 May 3 2013 xchat/
drwxr-xr-x 2 root wheel 3 Jun 28 2012 xotcl/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 zebra/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 znc/
drwxr-xr-x 2 root wheel 3 Jun 19 2012 zsh/
I suspect other people are just wondering WTF at all the changed options
and blaming poudriere-options, poudriere, or their sanity. Policy of
Least Astonishment, we're throwing away valid data here without a proper
conversion process documented or done automatically in all cases.
> except if set using poudriere options
> /me hates poudriere options :)
>
> Maybe poudriere should check the sanity of the options dir when running but that
> is another subject.
>
Uh, what? How does Poudriere come into this? It's no different than
building with BATCH and expecting your current options + new defaults to
be fine.
> That said I agree that 2 things should be restored: OPTIONSFILE= and the
> <name>_SET
>
> But we should absolutely not readd UNIQUENAME, so both should be based on
> PKGBASE.
>
> If OPTIONSILE is found a warning should be send to the users. with a deprecation
> notice.
>
> Best regards,
> Bapt
>
--
Regards,
Bryan Drewery
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20150904/56067762/attachment.bin>
More information about the svn-ports-head
mailing list