svn commit: r382100 - in head: archivers/pixz archivers/pixz/files dns/dualserver french/aster japanese/scim-skk news/nzbget ports-mgmt/bpm sysutils/freeipmi x11-wm/libcompizconfig

[Thierry Thomas]

On tue 24 mar 15 at 14:51:18 +0100, John Marino <marino at FreeBSD.org>
 wrote:

> Author: marino
> Date: Tue Mar 24 13:51:17 2015
> New Revision: 382100
> URL: https://svnweb.freebsd.org/changeset/ports/382100
> QAT: https://qat.redports.org/buildarchive/r382100/
> 
> Log:
>   8 ports categories: Remove $PTHREAD_LIBS
>   
>   Categories: archivers, dns, french, japanese, news, port-mgmt, x11-wm
>   
>   The sysutils port was setting configure argument, so the text wasn't
>   removed but the value of PTHREAD_LIBS was changed.
>   
>   approved by:	PTHREAD blanket
> 
> Modified:
>   head/archivers/pixz/Makefile
>   head/archivers/pixz/files/Makefile.in
>   head/dns/dualserver/Makefile
>   head/french/aster/Makefile
>   head/japanese/scim-skk/Makefile
>   head/news/nzbget/Makefile
>   head/ports-mgmt/bpm/Makefile
>   head/sysutils/freeipmi/Makefile
>   head/x11-wm/libcompizconfig/Makefile

8<	8<	8<

> Modified: head/french/aster/Makefile
> ==============================================================================
> --- head/french/aster/Makefile	Tue Mar 24 13:43:16 2015	(r382099)
> +++ head/french/aster/Makefile	Tue Mar 24 13:51:17 2015	(r382100)
> @@ -252,9 +252,9 @@ pre-configure:
>  	${ECHO_CMD} "F90='${FC}'"				>> ${WRKSRC}/setup.cfg
>  	${ECHO_CMD} "MATHLIB='${lib_math} ${LDFLAGS} -lgfortran -lm -lkvm'"		\
>  		>> ${WRKSRC}/setup.cfg
> -	${ECHO_CMD} "OTHERLIB='-Xlinker -export-dynamic -lutil ${PTHREAD_LIBS} -lz'"	\
> +	${ECHO_CMD} "OTHERLIB='-Xlinker -export-dynamic -lutil -lpthread -lz'"	\

I agree with you when you remove lines or patches such as

s/-lpthread/${PTHREAD_LIBS}/

but I disagree with your changes here: it's better to add
${PTHREAD_LIBS} than -lpthread.
-- 
Th. Thomas.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20150324/bbb19e3f/attachment.sig>