svn commit: r381955 - head/graphics/gdal

[Tijl Coosemans]

On Mon, 23 Mar 2015 22:05:05 +0100 Thierry Thomas <thierry at FreeBSD.org> wrote:
> Le lun 23 mar 15 à 19:29:48 +0100, John Marino <freebsd.contact at marino.st>
>  écrivait :
>>> Something like:
>>> LDFLAGS+=	${PTHREAD_LIBS}
>>> 
>>> In these cases, it seems better to keep PTHREAD_LIBS than to hardcode
>>> some variant of -lpthread.
>>> 
>>> Regards,
>>> 
>> 
>> see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198794
>> 
>> 1) it's set to -pthread right now
>> 2) PTHREAD_LIBS is supposed to disappear from ports.
> 
> I know, but I'm just suggesting to keep it for these cases.

It used to be the case on FreeBSD that when you linked an executable to
a library that used threading API you also had to link the executable
with a threading library.  So LDFLAGS+=${PTHREAD_LIBS} had to be added
to ports sometimes if one of their dependencies used threading.  It
should be safe to remove these uses of ${PTHREAD_LIBS} now and then
there won't be that many left.  I think it's ok to replace them with
-lpthread.  There are other libraries missing sometimes and they don't
have a special variable either.