svn commit: r381955 - head/graphics/gdal

[Bryan Drewery]

On 3/23/2015 9:33 AM, Baptiste Daroussin wrote:
> On Mon, Mar 23, 2015 at 09:24:13AM -0500, Bryan Drewery wrote:
>> On 3/23/2015 8:57 AM, Baptiste Daroussin wrote:
>>> On Sun, Mar 22, 2015 at 10:14:13PM -0500, Bryan Drewery wrote:
>>>> On 3/22/2015 8:58 PM, Alexey Dokuchaev wrote:
>>>>> On Sun, Mar 22, 2015 at 08:11:17PM +0000, Sunpoet Po-Chuan Hsieh wrote:
>>>>>> New Revision: 381955
>>>>>> URL: https://svnweb.freebsd.org/changeset/ports/381955
>>>>>> QAT: https://qat.redports.org/buildarchive/r381955/
>>>>>>
>>>>>> Log:
>>>>>>   - Use -lpthread instead of -pthread
>>>>>
>>>>> Is -pthread going away anytime soon?  I'm a bit worried of more alike
>>>>> changing one to another; since they're identical right now on FreeBSD,
>>>>> I'd rather reduce amount of patching, leaving whatever is picked by
>>>>> upstream, unless -lpthread really should be preferred over -pthread
>>>>> for some reason I'm unaware of (and ready to learn about).
>>>>>
>>>>> ./danfe
>>>>>
>>>>
>>>> It's a pointless change. Tijl explains here
>>>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198116#c4
>>>>
>>>
>>> This is not pointless at all this is a long standing thing that should be
>>> cleaned out for a while, portmgr already gave long ago some blanket to some
>>> developers to remove that along with all usage of PTHREAD_LIBS. The reason is
>>> that it is confusing for maintainers, as if they take example on some of our
>>> existing ports they might be driven in the wrong direction.
>>>
>>> Working in cleaning up those is imho important
>>>
>>> Regards,
>>> Bapt
>>>
>>
>> Reading the responses from David and Tijl I'm still at a loss at how
>> this is useful. From my understanding, and what David said, -pthread is
>> more portable. Reading documentation available from simple searching
>> leads me, as a naive developer, to use -pthread. Especially when looking
>> for Linux documentation. Using either is the same as the other on
>> FreeBSD as well. So why the major change?
>>
>> Removing PTHREAD_LIBS makes sense since it is a needless variable
>> leftover from a more complicated past. But why change -pthread to
>> -lpthread? Why not -lthr since -lpthread is actually an alias to that?
> 
> The goal is not to change anything but remove our gratuicious changes and
> patches.
> 
> Meaning I am not ok with s/pthread/lpthread/ but I'm ok with removing all
> PTHREAD_LIBS macros in ports and all patches we do use to replace lpthread with
> something else
> 
> Bapt
> 

Perfect. Thank you for clarifying your stance. I thought perhaps that
was what it was.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20150323/db8208c0/attachment.sig>