svn commit: r381955 - head/graphics/gdal

[John Marino]

On 3/23/2015 04:27, Alexey Dokuchaev wrote:
> On Sun, Mar 22, 2015 at 10:14:13PM -0500, Bryan Drewery wrote:
>> On 3/22/2015 8:58 PM, Alexey Dokuchaev wrote:
>>> On Sun, Mar 22, 2015 at 08:11:17PM +0000, Sunpoet Po-Chuan Hsieh wrote:
>>>> New Revision: 381955
>>>> URL: https://svnweb.freebsd.org/changeset/ports/381955
>>>> QAT: https://qat.redports.org/buildarchive/r381955/
>>>>
>>>> Log:
>>>>   - Use -lpthread instead of -pthread
>>>
>>> Is -pthread going away anytime soon?  I'm a bit worried of more alike
>>> changing one to another; since they're identical right now on FreeBSD,
>>> I'd rather reduce amount of patching, leaving whatever is picked by
>>> upstream, unless -lpthread really should be preferred over -pthread
>>> for some reason I'm unaware of (and ready to learn about).
>>
>> It's a pointless change. Tijl explains here
>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198116#c4
> 
> Right; I'm aware of Tijl's excellent explanation (broader version he posted
> on the lists) and given that it is a pointless change, I used this occasion
> to remind that commits that merely change one to another should be avoided.
> 

It's not pointless; people are patching good "-lpthread" to be
"-pthread" even today, and it's hard to tell them to stop when the
default PTHREADS_LIBS is "-pthread".

Also, this is not what tijl has been saying -- his stance was to stop
using -pthread.

We need not to add more -pthread, we need to remove patches and sed of
-lpthread to -pthread, and to do that we need to start at the
infrastructure to avoid sending a mixed message.

patching -lpthread to -pthread is simply wrong now, and the message
needs to get out.

John