svn commit: r381789 - in head/security/openssl: . files

[Alexey Dokuchaev]

On Sat, Mar 21, 2015 at 03:50:16PM +0100, Mathieu Arnold wrote:
> +--On 21 mars 2015 14:42:44 +0000 Alexey Dokuchaev <danfe at FreeBSD.org>
> wrote:
> | On Sat, Mar 21, 2015 at 02:15:52PM +0100, Mathieu Arnold wrote:
> |> +--On 21 mars 2015 10:53:14 +0000 Dirk Meyer <dinoex at FreeBSD.org> wrote:
> |> |  PORTNAME=	openssl
> |> | -PORTVERSION=	1.0.1
> |> | -DISTVERSIONSUFFIX=	m
> |> | -PORTREVISION=	19
> |> | +PORTVERSION=	1.0.2
> |> | +DISTVERSIONSUFFIX=	a
> |> | +PORTREVISION=	0
> |> 
> |> Would you consider setting PORTVERSION=1.0.2a and dropping
> |> DISTVERSIONSUFFIX ? It is mostly confusing to not have the openssl
> |> package have the real version all the time.
> | 
> | Except that is should probably be DISTVERSION, not PORTVERSION in this
> | case, to make it more "monotonic versions" friendly.
> 
> I'm not sure exactly what it would achieve, save, maybe not put the right
> version number where it should be.
> 
> $ pkg version -t 1.0.2 1.0.2a
> <
> $ pkg version -t 1.0.2a 1.0.2b
> <
> $ pkg version -t 1.0.2b 1.0.2c
> <
> $ pkg version -t 1.0.2d 1.0.2c

Hmm, perhaps in this case (OpenSSL) PORTVERSION in indeed correct choice,
sorry for the noise.

./danfe