svn commit: r381760 - in head/x11-fonts/sourcesanspro-ttf: . files

[Adam Weinberger]

> On 20 Mar, 2015, at 14:40, Bryan Drewery <bdrewery at FreeBSD.org> wrote:
> 
> On 3/20/2015 1:47 PM, Bryan Drewery wrote:
>> On 3/20/2015 1:43 PM, Adam Weinberger wrote:
>>> 
>>>> On 20 Mar, 2015, at 12:35, Baptiste Daroussin <bapt at FreeBSD.org> wrote:
>>>> 
>>>> On Fri, Mar 20, 2015 at 01:26:29PM -0500, Bryan Drewery wrote:
>>>>> On 3/20/2015 1:23 PM, Baptiste Daroussin wrote:
>>>>>> +WRKSRC=		${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME:S,/,-,}
>>>>> 
>>>>> I think we should put this globally in this 1 line:
>>>>> 
>>>>> bsd.port.mk
>>>>> 1561 .    if defined(GH_TAGNAME)
>>>>> 1562 WRKSRC?=        ${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME}
>>>>> 
>>>>> 
>>>>> After https://reviews.freebsd.org/D2103 is resolved I will fix that.
>>>> 
>>>> Almost in this case upstream decided to put a / in the TAGNAME which is ... well
>>>> ... :)
>>> 
>>> It would be so unbelievably nice if we had a way to just specify the destination filename, using fetch -o. All the bizarre names that files are published as, the unversioned tarballs, the documentation files labelled Documentation.pdf, and the fallout from changes like this.... we could make our lives so much easier with a DISTFILE_DEST variable.
>>> 
>>> # Adam
>>> 
>>> 
>> 
>> For USE_GITHUB that is exactly what DISTNAME is. You can name it
>> whatever you want.
>> 
>> As for your other examples I agree. I'll look into that!
>> 
> 
> Thinking about it a bit more I don't have time to implement this today
> or soon.
> 
> DISTFILES would need a syntax to specify an output filename. The
> do-fetch and do-checksum targets in bsd.port.mk would need a lot of
> rework. They are very risky to touch and hard to maintain as is.
> 
> Ideas for a DISTFILES format?

I think what you're talking about is essentially overloading the DISTFILES variable to be usable as a template, correct? Wouldn't:

.if defined(DISTFILE_DEST)
FETCH_ARGS += -o ${DISTFILE_DEST}
DISTFILES += ${DISTFILE_DEST}
.endif

be simpler? I'll be honest, I haven't looked into the do-fetch and do-checksum targets yet, but specifying the destination filename manually means that you already know exactly what needs to be added to DISTFILES.

# Adam


-- 
Adam Weinberger
adamw at adamw.org
http://www.adamw.org