svn commit: r381680 - in head/x11-fonts: font-sun-misc font-winitzki-cyrillic font-xfree86-type1

[Baptiste Daroussin]

On Thu, Mar 19, 2015 at 05:47:13PM -0500, Bryan Drewery wrote:
> On 3/19/2015 5:06 PM, Baptiste Daroussin wrote:
> > On Thu, Mar 19, 2015 at 02:52:54PM -0500, Bryan Drewery wrote:
> >> On 3/19/2015 2:40 PM, Antoine Brodin wrote:
> >>> Author: antoine
> >>> Date: Thu Mar 19 19:40:56 2015
> >>> New Revision: 381680
> >>> URL: https://svnweb.freebsd.org/changeset/ports/381680
> >>> QAT: https://qat.redports.org/buildarchive/r381680/
> >>>
> >>> Log:
> >>>   Add missing BUILD_DEPENDS and CONFIGURE_ARGS
> >>>
> >>> Modified:
> >>>   head/x11-fonts/font-sun-misc/Makefile
> >>>   head/x11-fonts/font-winitzki-cyrillic/Makefile
> >>>   head/x11-fonts/font-xfree86-type1/Makefile
> >>>
> >>> Modified: head/x11-fonts/font-sun-misc/Makefile
> >>> ==============================================================================
> >>> --- head/x11-fonts/font-sun-misc/Makefile	Thu Mar 19 19:38:48 2015	(r381679)
> >>> +++ head/x11-fonts/font-sun-misc/Makefile	Thu Mar 19 19:40:56 2015	(r381680)
> >>> @@ -4,15 +4,18 @@
> >>>  PORTNAME=	font-sun-misc
> >>>  PORTVERSION=	1.0.3
> >>>  PORTREVISION=	2
> >>> -MASTER_SITES=	XORG
> >>> -MASTER_SITE_SUBDIR=	individual/font
> >>> +MASTER_SITES=	XORG/individual/font
> >>>  CATEGORIES=	x11-fonts
> >>>  
> >>>  MAINTAINER=	x11 at FreeBSD.org
> >>>  COMMENT=	X.Org miscellaneous Sun fonts
> >>>  
> >>> +BUILD_DEPENDS=	bdftopcf:${PORTSDIR}/x11-fonts/bdftopcf \
> >>> +		mkfontdir:${PORTSDIR}/x11-fonts/mkfontdir
> >>> +
> >>>  USES=		fonts tar:bzip2
> >>>  FONTNAME=	misc
> >>>  GNU_CONFIGURE=	yes
> >>> +CONFIGURE_ARGS=	--with-fontrootdir=${PREFIX}/lib/X11/fonts
> >>>  
> >>
> >> How is this an improvement over XORG_CAT? There's like 6 more lines than
> >> before.
> >>
> >> Should those BUILD_DEPENDS be in fonts.mk?
> > 
> > The improvement is in the fact that XORG_CAT is doing wrong things with fonts,
> > while fonts.mk is not.
> > 
> > Sure I can add an argument to fonts.mk to reduce avoid duplicating things
> > 
> > Best regards,
> > Bapt
> > 
> 
> Why not fix XORG_CAT?
> 
Because XORG_CAT only works with xorg's fonts not for all fonts while with
fonts.mk we can have the same behavious for all fonts (the others fonts are
wrong as well)

Best regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20150320/13cc3539/attachment.sig>