svn commit: r395409 - head/astro/geographiclib

Dmitry Marakasov amdmi3 at amdmi3.ru
Thu Aug 27 11:33:16 UTC 2015


* John Marino (freebsd.contact at marino.st) wrote:

> >>> New Revision: 395409
> >>> URL: https://svnweb.freebsd.org/changeset/ports/395409
> >>>
> >>> [...]
> >>>  GRAVITY_NAMES:=		egm84 egm96 egm2008 wgs84 grs80
> >>> -MAGNETIC_NAMES:=	wmm2010 wmm2015 igrf11 igrf12 emm2010
> >>> +MAGNETIC_NAMES:=	wmm2010 wmm2015 igrf11 igrf12 emm2010 emm2015
> >>
> >> Why := (assignment with immediate expansion) is used here, esp. for constant
> >> values?
> > 
> > Ask maintainer.
> 
> I thought it had been clearly established (by mat@ IIRC) that this kind
> of response is not acceptable as a reason for ports mistakes.  The
> committer is supposed to review the port he or she is committing and
> catch errors.  The maintainers simply don't have the same level of
> experience as committers do.

I'll repeat the same thing I've said back then: I don't see it as
a mistake, that is exactly why I've committed it without modification.

"There's no difference whether variable is assigned with or without
expansion as long as the assigned value does not contain other variable
references" - that's what I'd answer if you asked _why_ I committed it
as-is, but you've asked another question, and that question may only
be directed to maintainer.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3 at amdmi3.ru  ..:  jabber: amdmi3 at jabber.ru      http://amdmi3.ru


More information about the svn-ports-head mailing list