svn commit: r394949 - head/Mk
Jan Beich
jbeich at FreeBSD.org
Sun Aug 23 23:05:28 UTC 2015
John Marino <freebsd.contact at marino.st> writes:
> On 8/21/2015 2:30 PM, Jan Beich wrote:
>
>> Author: jbeich
>> Date: Fri Aug 21 12:30:03 2015
>> New Revision: 394949
>> URL: https://svnweb.freebsd.org/changeset/ports/394949
>>
>> Log:
>> gecko: properly check OSVERSION against OPSYS [1]
>>
>> Bundled jemalloc is left enabled for DragonFly due to lack of
>> documented evidence it doesn't work: failed build log, crash
>> fingerprint, upstream bug, etc. jemalloc upstream unlike its
>> Mozilla fork (not used here) has better support for BSDs.
>>
>
> Here's the documented evidence.
>
> Stock bsd.gecko.mk:
> http://muscles.dragonflybsd.org/bulk/bleeding-edge-potential/20150822_041034/logs/errors/firefox-40.0_6,1.log
[...]
> Executing /wrkdirs/www/firefox/work/mozilla-release/obj-x86_64-portbld-dragonfly4.3/dist/bin/xpcshell -g /wrkdirs/www/firefox/work/mozilla-release/obj-x86_64-portbld-dragonfly4.3/dist/bin/ -a /wrkdirs/www/firefox/work/mozilla-release/obj-x86_64-portbld-dragonfly4.3/dist/bin/ -f /wrkdirs/www/firefox/work/mozilla-release/toolkit/mozapps/installer/precompile_cache.js -e precompile_startupcache("resource://gre/");
> Traceback (most recent call last):
> File "/wrkdirs/www/firefox/work/mozilla-release/toolkit/mozapps/installer/packager.py", line 404, in <module>
> main()
> File "/wrkdirs/www/firefox/work/mozilla-release/toolkit/mozapps/installer/packager.py", line 398, in main
> args.source, gre_path, base)
> File "/wrkdirs/www/firefox/work/mozilla-release/toolkit/mozapps/installer/packager.py", line 156, in precompile_cache
> errors.fatal('Error while running startup cache precompilation')
> File "/wrkdirs/www/firefox/work/mozilla-release/python/mozbuild/mozpack/errors.py", line 101, in fatal
> self._handle(self.FATAL, msg)
> File "/wrkdirs/www/firefox/work/mozilla-release/python/mozbuild/mozpack/errors.py", line 96, in _handle
> raise ErrorMessage(msg)
> mozpack.errors.ErrorMessage: Error: Error while running startup cache precompilation
> /wrkdirs/www/firefox/work/mozilla-release/toolkit/mozapps/installer/packager.mk:36: recipe for target 'stage-package' failed
> gmake[4]: *** [stage-package] Error 1
Thanks. This requires a backtrace to be able to distinguish from other
xpcshell crashes e.g., currently on FreeBSD 8.4R and powerpc. I'd check
if disabling TLS helps in case of bootstrapping issue.
--- memory/jemalloc/src/configure.ac~
+++ memory/jemalloc/src/configure.ac
@@ -273,16 +273,17 @@ case "${host}" in
abi="elf"
AC_DEFINE([JEMALLOC_PURGE_MADVISE_FREE], [ ])
force_lazy_lock="1"
;;
*-*-dragonfly*)
CFLAGS="$CFLAGS"
abi="elf"
AC_DEFINE([JEMALLOC_PURGE_MADVISE_FREE], [ ])
+ force_tls="0"
;;
*-*-linux*)
CFLAGS="$CFLAGS"
CPPFLAGS="$CPPFLAGS -D_GNU_SOURCE"
abi="elf"
AC_DEFINE([JEMALLOC_HAS_ALLOCA_H])
AC_DEFINE([JEMALLOC_PURGE_MADVISE_DONTNEED], [ ])
AC_DEFINE([JEMALLOC_THREADED_INIT], [ ])
--- memory/jemalloc/src/configure~
+++ memory/jemalloc/src/configure
@@ -4857,16 +4857,17 @@ case "${host}" in
force_lazy_lock="1"
;;
*-*-dragonfly*)
CFLAGS="$CFLAGS"
abi="elf"
$as_echo "#define JEMALLOC_PURGE_MADVISE_FREE " >>confdefs.h
+ force_tls="0"
;;
*-*-linux*)
CFLAGS="$CFLAGS"
CPPFLAGS="$CPPFLAGS -D_GNU_SOURCE"
abi="elf"
$as_echo "#define JEMALLOC_HAS_ALLOCA_H 1" >>confdefs.h
$as_echo "#define JEMALLOC_PURGE_MADVISE_DONTNEED " >>confdefs.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 602 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20150823/ea93a459/attachment.bin>
More information about the svn-ports-head
mailing list