svn commit: r394970 - head/devel/love07

Mathieu Arnold mat at FreeBSD.org
Fri Aug 21 21:46:42 UTC 2015


+--On 21 août 2015 18:53:36 +0000 Alexey Dokuchaev <danfe at FreeBSD.org>
wrote:
| After we entered staging era, we started to get rid of .if ${PORTDOCS}
| checks because we could use the benefit of dumping everything possible [1]

No.

Dropping the .if ${PORT_OPTIONS:MDOCS} checks was to avoid getting hit by
having to include bsd.port.options.mk, which includes bsd.port.mk, and
thus, make had to parse it twice (once from bsd.port.options.mk, once at
the end of the Makefile), which takes time.  So, we started installing docs
files in post-install when there was "not too much of them", installing
them inconditionnaly was supposed to be a less hit than parsing bsd.port.mk
twice.

I added target options helpers (and rewrote the target ordering mechanism
on the way), so we still do not need bsd.port.options.mk to check for
PORT_OPTIONS:MDOCS/EXAMPLES/WHATEVEROPT, saving us from parsing bsd.port.mk
twice, but now, only installing the files when they're needed, and not
always.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20150821/37d0c9a5/attachment.bin>


More information about the svn-ports-head mailing list