svn commit: r358059 - head/audio/x11amp

[Antoine Brodin]

On Tue, Jun 24, 2014 at 1:36 PM, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> On Tue, Jun 24, 2014 at 01:21:57PM +0200, Antoine Brodin wrote:
>> On Tue, Jun 24, 2014 at 1:12 PM, Alexey Dokuchaev <danfe at freebsd.org> wrote:
>> > On Mon, Jun 16, 2014 at 10:46:47PM +0000, Dmitry Marakasov wrote:
>> >> New Revision: 358059
>> >> URL: http://svnweb.freebsd.org/changeset/ports/358059
>> >> QAT: https://qat.redports.org/buildarchive/r358059/
>> >>
>> >> Log:
>> >>   - Switch to USES=libtool, drop .la files
>> >>   - Mark BROKEN, does not run (BROKENness is not related to libtool change)
>> >> [...]
>> >> +BROKEN=              hangs at start with gtk and linker errors
>> >
>> > Looks like it you should've used IGNORE instead (run-time problem).
>>
>> No BROKEN is fine in this case.
>
> What does "hangs at start" mean?  x11amp is invoked during the build for
> some sanity testing?
>
> If the build goes fine (without error), it should be IGNORE, not BROKEN.

I disagree,  if a port build but doesn't run,  it must not be hidden
behind IGNORE and must be marked BROKEN.
And I will deprecate it in 6 months!

Bye bye!

Antoine