svn commit: r357248 - in head/games/moria: . files

Alexey Dokuchaev danfe at FreeBSD.org
Tue Jun 10 06:52:12 UTC 2014


On Tue, Jun 10, 2014 at 03:22:24AM +0000, Greg Lewis wrote:
> New Revision: 357248
> URL: http://svnweb.freebsd.org/changeset/ports/357248
> QAT: https://qat.redports.org/buildarchive/r357248/
> 
> +MAKE_ENV+=	DOCSDIR="${DOCSDIR}" MKDIR="${MKDIR}" TOUCH="${TOUCH}" \
> +		STAGEDIR="${STAGEDIR}" DATADIR="${DATADIR}"

What's wrong with default DESTDIR?

> -+	${MKDIR} ${DOCSDIR}
> -+	${BSD_INSTALL_DATA} ${FILES} ${DOCSDIR}
> ++	${MKDIR} ${STAGEDIR}${DOCSDIR}
> ++	${BSD_INSTALL_DATA} ${FILES} ${STAGEDIR}${DOCSDIR}

That should be used here instead of STAGEDIR.  Not just it would allow you
do drop that from MAKE_ENV/ARGS, it would also make it easier to integrate
these patches back upstream (DESTDIR is standard name, STAGEDIR is not).

./danfe


More information about the svn-ports-head mailing list