svn commit: r362762 - head/sysutils/freeipmi

[Tijl Coosemans]

On Thu, 24 Jul 2014 05:11:55 +0000 (UTC) Sunpoet Po-Chuan Hsieh wrote:
> Author: sunpoet
> Date: Thu Jul 24 05:11:54 2014
> New Revision: 362762
> URL: http://svnweb.freebsd.org/changeset/ports/362762
> QAT: https://qat.redports.org/buildarchive/r362762/
> 
> Log:
>   - Fix build on 11-CURRENT
> 
> Modified:
>   head/sysutils/freeipmi/Makefile
> 
> Modified: head/sysutils/freeipmi/Makefile
> ==============================================================================
> --- head/sysutils/freeipmi/Makefile	Thu Jul 24 05:01:54 2014	(r362761)
> +++ head/sysutils/freeipmi/Makefile	Thu Jul 24 05:11:54 2014	(r362762)
> @@ -24,7 +24,7 @@ CONFIGURE_ARGS=	--disable-init-scripts \
>  		--with-ipmi-monitoring-sdr-cache-dir=${CACHE_DIR}/ipmimonitoringsdrcache \
>  		--with-pkgconfig-dir=${PREFIX}/libdata/pkgconfig
>  CONFIGURE_ENV=	PTHREAD_LIBS=-pthread ac_cv_path_CPP=${CPP}
> -CPPFLAGS+=	-I${LOCALBASE}/include
> +CPPFLAGS+=	-fPIC -I${LOCALBASE}/include

Adding -fPIC like that is almost always wrong, because now you also
build executables and static libraries with it.

This port builds fine without -fPIC on beefy and redports so what
exactly is the problem?

Same for r362761.