svn commit: r342718 - head/audio/libmad

[Baptiste Daroussin]

On Wed, Feb 05, 2014 at 04:53:19PM +0100, Tijl Coosemans wrote:
> On Wed, 05 Feb 2014 16:38:41 +0100 Mathieu Arnold wrote:
> > +--On 5 février 2014 16:35:22 +0100 Mathieu Arnold <mat at FreeBSD.org> wrote:
> >| +--On 5 février 2014 15:29:37 +0000 Sunpoet Po-Chuan Hsieh
> >| <sunpoet at FreeBSD.org> wrote:
> >|| Author: sunpoet
> >|| Date: Wed Feb  5 15:29:37 2014
> >|| New Revision: 342718
> >|| URL: http://svnweb.freebsd.org/changeset/ports/342718
> >|| QAT: https://qat.redports.org/buildarchive/r342718/
> >|| 
> >|| Log:
> >||   - Use USES=libtool
> >|| 
> >|| Modified:
> >||   head/audio/libmad/Makefile
> >|| 
> >|| Modified: head/audio/libmad/Makefile
> >|| =========================================================================
> >|| ===== --- head/audio/libmad/Makefile	Wed Feb  5 15:29:04 2014	(r342717)
> >|| +++ head/audio/libmad/Makefile	Wed Feb  5 15:29:37 2014	(r342718) @@
> >|| -15,8 +15,8 @@ SPEED_DESC=	Optimize for speed over accu
> >||  
> >||  CONFIGURE_ARGS=	--disable-debugging --enable-sso
> >||  GNU_CONFIGURE=	yes
> >|| -USE_AUTOTOOLS=	libtool
> >||  USE_LDCONFIG=	yes
> >|| +USES=		libtool
> >||  
> >||  SUB_LIST=	VERSION=${PORTVERSION}
> >||  SUB_FILES=	mad.pc
> >|| 
> >| 
> >| I'm quite sure you forgot to update the plist.
> > 
> > And quite possibly bump PORTREVISION in the ports that depend on it.
> 
> USES=libtool also decrements the library version in this case which
> should be avoided, so you have to patch the port to decrement age until
> the library version is the same as before.  I've attached a patch which
> does this.

I don't think we should avoid decrementing shlib numbers in that case we are
going back to normal situation just it needs to be chased, in my opinion.

BTW: I have committed a fix

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20140205/dfc5de12/attachment.sig>