svn commit: r342587 - head/x11/pixman

Alexey Dokuchaev danfe at FreeBSD.org
Wed Feb 5 12:15:25 UTC 2014


On Tue, Feb 04, 2014 at 09:09:59PM +0100, Tijl Coosemans wrote:
> The is a bit strange because if you turn off SIMD you still get MMX and
> SSE2 support if your cpu supports it.  It should be something like this:
> 
> .if ! ${PORT_OPTIONS:MSIMD}
> CONFIGURE_ARGS=	--disable-vmx --disable-arm-simd --disable-mmx \
> 		--disable-sse2
> .endif
> 
> But then you're still missing --disable-ssse3 and a number of ARM and
> MIPS SIMD options (reported by ./configure --help).
> 
> I think it's best to just remove this whole block together with the
> SIMD option because pixman tests at runtime what features the cpu
> supports so in my opinion there's no reason to disable SIMD support.

+1.  I've always had to read inside the Makefile to understand what does
this option do; it's very confusing up-front.  Please remove it and/or
hide the logic behind the trunk, so it DTRT without annoying users with
cryptic dialogs.  Thank you. :)

./danfe


More information about the svn-ports-head mailing list