svn commit: r341510 - head/lang/libobjc2

[Baptiste Daroussin]

On Mon, Feb 03, 2014 at 10:33:23AM +0000, David Chisnall wrote:
> On 3 Feb 2014, at 10:15, Tijl Coosemans <tijl at FreeBSD.org> wrote:
> > 
> > The port is currently broken.  By removing the bsd.port.pre.mk include
> > -DCMAKE_C_COMPILER:STRING="${CC}" in Uses/cmake.mk now comes after the
> > -DCMAKE_C_COMPILER=${CLANG} here so it doesn't have any effect.  Same for
> > CXX.
> > 
> > Instead of putting .include <bsd.port.pre.mk> back, maybe the port should
> > define CC=${CLANG} CXX=${CLANGXX} and remove the second CMAKE_ARGS line?
> 
> Indeed.  This is currently a bit of a hack.  Ideally, we should remove that ugliness and have a USES=compiler:objc (ideally objc-1.7 to specify the runtime ABI version), which would give us clang from either ports or base depending on whether there is one in base and what its version is.
> 

I did a quick fix, I'm all for a compiler:objc !!

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20140203/958a41f0/attachment.sig>