svn commit: r375696 - head/multimedia/libx264

[Kubilay Kocak]

On 28/12/2014 10:05 PM, David Chisnall wrote:
> On 28 Dec 2014, at 12:00, Kubilay Kocak <koobs at FreeBSD.org> wrote:
> 
>> (eg: PGO until libprofile_rt in Clang lands in FreeBSD), whether or not
>> 4.2.1 provided statistically significant benefits over later versions.
> 
> Shouldn't PGO be something handled by the compiler USES flags, rather than hard-coding it in here and every other port that has a PGO option?
> 
> David
> 

Sounds reasonable. We already have :openmp, so a :pgo doesn't seem too
far-fetched.

It may or may not matter to the question, but in x264's case, there is
also a custom build target that is run for PGO along with the subsequent
multi-pass encoding runs.

If we could keep any extra PGO logic needed in ports while outsourcing
the compiler selection, that sounds like a net gain.

Koobs