svn commit: r375010 - head/Mk

[Adam Weinberger]

> On Dec 21, 2014, at 10:48, Steve Wills <swills at FreeBSD.org> wrote:
> 
> On 12/21/14 15:15, Adam Weinberger wrote:
>>> On 20 Dec, 2014, at 8:59, Steve Wills <swills at freebsd.org>
>>> wrote:
>>> 
>>> Author: swills Date: Sat Dec 20 15:59:46 2014 New Revision:
>>> 375010 URL: https://svnweb.freebsd.org/changeset/ports/375010 
>>> QAT: https://qat.redports.org/buildarchive/r375010/
>>> 
>>> Log: Make using GitHub releases easier
>>> 
>>> Differential Revision:    https://reviews.freebsd.org/D1340 With
>>> hat:    portmgr
>>> 
>>> -# -# GitHub files can also be obtained, without the need for any
>>> of the above, by doing: -# -# MASTER_SITES=
>>> http://github.com/accountname/${PORTNAME}/archive/${PORTVERSION}.tar.gz?dummy=/
> -#
>> 
>> That shortcut code still works, and it's still simpler than using 
>> USE_GITHUB and having to keep track of commit hashes on every
>> update. Why remove it?
>> 
>> The PH says, "If the distribution file comes from a specific
>> commit or tag on GitHub for which there is no officially released
>> file, [...]". That code block is a way to get it when there IS an 
>> officially released file.
> 
> Wouldn't you still have to do work to update the distinfo if the
> commit hash changes?

Sure, same as other ports. Only difference is that, same as other ports, you don't need to come up with the commit SHA hash as well. You're portmgr, it's your call of course, I just thought it was a nice alternative for ports with release tarballs on github to use a simpler method.

# Adam


--
Adam Weinberger
adamw at adamw.org
http://www.adamw.org