svn commit: r374867 - head/sysutils/lsof

[Larry Rosenman]

On 2014-12-18 11:54, Larry Rosenman wrote:
> On 2014-12-18 11:36, Andrey Chernov wrote:
>> BTW, all it happens because 'bool' type is defined in <sys/types.h> 
>> only
>> for _KERNEL case and lsof explicitly don't want to define _KERNEL 
>> before
>> including <sys/types.h> as their dlsof.h comment states.
>> 
>> While not defining _KERNEL for <sys/types.h> they temporarily define 
>> it
>> while including <sys/proc.h> which cause this bug.
> 
> I've sent this thread to Vic Abell, LSOF author, for comment.
> 
> Larry Rosenman
> sysutils/lsof maintainer.

as this does NOT happen on my amd64 10.1-STABLE box (which is where Vic 
tests), we're going to need access to one of the failing boxes.

Can anyone help here?


> 
>> 
>> On 18.12.2014 18:45, Andrey Chernov wrote:
>>> On 18.12.2014 18:18, Bryan Drewery wrote:
>>>> On 12/18/2014 6:34 AM, Andrey Chernov wrote:
>>>>> On 17.12.2014 21:33, Bryan Drewery wrote:
>>>>>> Log:
>>>>>>   - Update to 4.89A, which should fix head builds.
>>>>> 
>>>>> Attempting to build it on -stable x86 is not successful:
>>>>> 
>>>>> --- dmnt.o ---
>>>>> cc  -pipe -march=core2 -fstack-protector -fno-strict-aliasing
>>>>> -march=core2 -DHASTASKS -DHAS_PAUSE_SBT -DHASEFFNLINK=i_effnlink
>>>>> -DHASF_VNODE -DHAS_FILEDESCENT -DHAS_TMPFS -DHASWCTYPE_H 
>>>>> -DHASSBSTATE
>>>>> -DHAS_KVM_VNODE -DHAS_UFS1_2 -DHAS_VM_MEMATTR_T -DHAS_CDEV2PRIV
>>>>> -DHAS_NO_SI_UDEV -DHAS_SYS_SX_H -DHAS_ZFS -DHAS_V_LOCKF
>>>>> -DHAS_LOCKF_ENTRY -DHAS_NO_6PORT -DHAS_NO_6PPCB -DNEEDS_BOOLEAN_T
>>>>> -DFREEBSDV=10000 -DHASFDESCFS=2 -DHASPSEUDOFS -DHASNULLFS -DHASIPv6
>>>>> -DHASUTMPX -DHAS_STRFTIME -DLSOF_VSTR=\"10.1-STABLE\" 
>>>>> -I/usr/src/sys -O2
>>>>> -c dmnt.c
>>>>> In file included from dmnt.c:39:
>>>>> In file included from ./lsof.h:195:
>>>>> In file included from ./dlsof.h:208:
>>>>> In file included from /usr/src/sys/ufs/ufs/ufsmount.h:36:
>>>>> In file included from /usr/src/sys/sys/buf.h:260:
>>>>> /usr/src/sys/sys/proc.h:950:1: error: unknown type name 'bool'
>>>>> bool    thread_suspend_check_needed(void);
>>>>> ^
>>>>> --- lib/liblsof.a ---
>>>>> --- ckkv.o ---
>>>>> In file included from ckkv.c:43:
>>>>> In file included from ./../lsof.h:195:
>>>>> In file included from ./../dlsof.h:208:
>>>>> In file included from /usr/src/sys/ufs/ufs/ufsmount.h:36:
>>>>> In file included from /usr/src/sys/sys/buf.h:260:
>>>>> /usr/src/sys/sys/proc.h:950:1: error: unknown type name 'bool'
>>>>> bool    thread_suspend_check_needed(void);
>>>>> ^
>>>>> 1 error generated.
>>>>> *** [ckkv.o] Error code 1
>>>>> 
>>>> 
>>>> Can you please verify your SRC_BASE is pointed to the right src 
>>>> tree?
>>>> adamw@ ran into the same issue and found they had the wrong src tree
>>>> checked in use.
>>>> 
>>> 
>>> On this machine I have only one src tree which is updated to latest
>>> -stable for /usr/src (and latest ports for /usr/ports).
>>> 
>>> F.e. mentioned /usr/src/sys/sys/proc.h is
>>> $FreeBSD: stable/10/sys/sys/proc.h 275794 2014-12-15 10:46:07Z kib $
>>> 

-- 
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 214-642-9640                 E-Mail: ler at lerctr.org
US Mail: 108 Turvey Cove, Hutto, TX 78634-5688