svn commit: r374800 - head/Mk/Uses

[Bryan Drewery]

On 12/18/2014 6:00 AM, John Marino wrote:
> On 12/18/2014 12:11, Baptiste Daroussin wrote:
>> On Tue, Dec 16, 2014 at 07:43:55PM -0600, Bryan Drewery wrote:
>>> On 12/16/2014 8:24 AM, Alexey Dokuchaev wrote:
>>>> On Tue, Dec 16, 2014 at 04:13:20PM +0200, Alex Kozlov wrote:
>>>>> On Tue, Dec 16, 2014 at 02:47:09PM +0100, Mathieu Arnold wrote:
>>>>>> +--On 16 d'ecembre 2014 15:38:02 +0200 Alex Kozlov <ak at FreeBSD.org> wrote:
>>>>>> | Allow me to ask, why it should be 8 and not 4?
>>>>>>
>>>>>> Because a tabulation is 8 spaces.  It should be consistent over the whole
>>>>>> ports tree.
>>>>>
>>>>> Well, 'Please view me with 4 column tabs!' line was added to bsd.port.mk
>>>>> more than 20 year ago, in rev 69, because it's inconvenient to view it with
>>>>> default tabulation value: many wrapped lines, indentation too deep, etc.
>>>>
>>>> I think I agree with Alex here.  While most of us prefer ts=8, I don't see
>>>> the need to reindent some files, most notably b.p.m., as it will completely
>>>> jeopardize its history and make 'svn blame' basically useless.
>>>>
>>>> Even with editors that cannot grok ex:ts=X hints, its not that hard to do it
>>>> manually every time you need to view/edit these files.  I do it all the time
>>>> with nvi(1).
>>>>
>>>> ./danfe
>>>>
>>>
>>> As a vendor who maintains a forked ports tree, I despise this commit and
>>> all of the ones below. It makes carrying out customizations very
>>> difficult. Yes, it doesn't *look* good on the eyes, but reindenting on
>>> such large files with large history maintained by > 1 person is a sin.
>>>
>>>
>> Wow that makes impressive to quote that whole list of commits, among those
>> changes a few are really changing things more than a few comments, and most of
>> which are files that are either removed and/or heavily worked on at the time,
>> there are yes 1 or 2 maybe controversial here but that is all.
>>
> 
> I'm a bit disappointed that "svn blame" output is considered more
> important than doing the right thing, myself.  It's a tool, not a
> constitutional by-law.  Just fix all the Mk files at once.
> 
> John
> 

I actually thought that had already been done by bapt and am now
surprised we're dealing with it again/still.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20141218/cbdf67df/attachment.sig>