svn commit: r374466 - head/Mk

Alexey Dokuchaev danfe at FreeBSD.org
Wed Dec 10 15:58:36 UTC 2014


On Wed, Dec 10, 2014 at 04:54:18PM +0100, Mathieu Arnold wrote:
> +--On 10 d'ecembre 2014 15:19:52 +0000 Alexey Dokuchaev <danfe at FreeBSD.org>
> wrote:
> | On Wed, Dec 10, 2014 at 03:10:40PM +0000, Mathieu Arnold wrote:
> |> New Revision: 374466
> |> URL: https://svnweb.freebsd.org/changeset/ports/374466
> |> QAT: https://qat.redports.org/buildarchive/r374466/
> |> 
> |> Log:
> |>   Patches go into PATCHDIR, not FILESDIR.
> |>   
> |>   Pointy hat to:	Everybody that looked at the code review, me included.
> | 
> | Not really; I recall there was an idea to get rid of PATCHDIR altogether,
> | it's more of a relic these days.  FILESDIR works equally well and makes
> | more sense (i.e. there is "files" directory and no "patches").
> 
> Maybe, but then, someone has to remove all of PATCHDIR, because before this
> fix, the framework would look at the patches in PATCHDIR, and save them in
> FILESDIR.

Basically, yes, since vast majority of ports assumes that PATCHDIR ==
FILESDIR (and it is true by default), it should be fairly easy to fix the
edge cases and remove PATCHDIR.  Sounds like a good idea for a Phabricator
issue.

./danfe


More information about the svn-ports-head mailing list