svn commit: r327601 - head/Mk

[Bryan Drewery]

On 10/11/2013 7:37 PM, Gerald Pfeifer wrote:
> On Sat, 21 Sep 2013, Bryan Drewery wrote:
>> We also plan to add more commit hooks for things that portlint has
>> checked for. Not everyone runs portlint, and portlint is essentially
>> unmaintained. It is currently severely lagging behind in feature-set
>> checking. By moving to ports, the feature-set checking is always
>> matching the tree.
> 
> This is a bit confusing, and I think there are things portlint checks
> for that the ports infrastructure cannot?
> 
> For example, a recent sweep to replace LAST_LINK by PKGNAMESUFFIX
> triggered new portlint warnings for me since PKGNAMESUFFIX was added
> at the wrong place.

This static analysis could be done by a hook.

> 
> I thought we all are supposed to run portlint before commits?

Yes, but it's severely outdated and no one has stepped up to fix that or
take proper maintainership of it. It currently gives incorrect advice on
multiple common cases.

> 
> Gerald
> 


-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20131011/fe5c6d6f/attachment.sig>