svn commit: r316469 - head/databases/slony1v2

[Jung-uk Kim]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-04-24 15:30:57 -0400, Chris Rees wrote:
> On 24 April 2013 20:21, Jung-uk Kim <jkim at freebsd.org> wrote:
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
>> 
>> On 2013-04-24 15:08:00 -0400, Jimmy Olgeni wrote:
>>> 
>>> On Wed, 24 Apr 2013, Jung-uk Kim wrote:
>>> 
>>>> On 2013-04-24 14:50:57 -0400, Jimmy Olgeni wrote:
>>>>> Author: olgeni Date: Wed Apr 24 18:50:57 2013 New
>>>>> Revision: 316469 URL:
>>>>> http://svnweb.freebsd.org/changeset/ports/316469
>>>>> 
>>>>> Log: - Use bsd.port.options.mk. - PORTDOCS should not be 
>>>>> conditional. - Whitespace fix.
>>>> ...
>>>> 
>>>> bsd.port.mk says "(PORTDOCS) should not be set when no 
>>>> documentation files are installed" and I believe it is
>>>> actually correct.
>>> 
>>> I found this on the Porter's Handbook:
>>> 
>>> If a directory is listed in PORTDOCS or matched by a glob
>>> pattern from this variable, the entire subtree of contained
>>> files and directories will be registered in the final packing
>>> list. If the DOCS option has been unset then files and
>>> directories listed in PORTDOCS would not be installed or added
>>> to port packing list.
>>> 
>>> It seems to behave correctly, at least in the PORTDOCS=* case.
>> 
>> It may work for now because bsd.options.mk has backward compat
>> shim, i.e.,
>> 
>> ## Now some compatibility .if empty(PORT_OPTIONS:MDOCS) 
>> NOPORTDOCS=     yes .endif
>> 
>> It won't work when we deprecate the compat shims.
> 
> Yes, bsd.port.mk needs fixing there.

Agreed.

We should refrain from blindly making PORTDOCS unconditional until we
resolve the issue, IMHO.

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iQEcBAEBAgAGBQJReDRiAAoJECXpabHZMqHOs1QH/0abe9AgMBkuLyY9IBg198Q8
0Whp8Of/Ko57JhZVLV1xA5PmSrlKjg1uNiRD5PXPSbxXdn2tX1c2heuA5v+vHDSj
5ef2YuLJ89yaUc9YdRC3FJo4mUS+4HPaLFO20RqQoFC1+K+OAEk6OKRyrLTVMFCh
p5K7q5BCI47UiZ38CJrE4m9uM0yGWe9S2KGX47IO2xB8voEKsqEnGk9r3NEprzrj
FhZs3MSadROkY98HXDD5iThPP8nL2SXEa6LTEsBQZflcpOnajjgjQo4ZTJW0/ch7
/24qmCT6Yj71zGeZyxi4Ics7OrLqA+f7BWz0FdrrfZktyq7Vf65XwU/QQ8vIf2c=
=lbEf
-----END PGP SIGNATURE-----