svn commit: r315222 - in head: devel/qdevelop games/warmux graphics/xaos math/qtiplot multimedia/minitube print/hplip textproc/qstardict

[Max Brazhnikov]

On Thu, 04 Apr 2013 17:24:32 +0800 Sunpoet Po-Chuan Hsieh wrote:
> I think these options can be used globally and also per port. These options
> are just on by default via bsd.options.mk. Users should be able to turn
> them off through options dialog while building/installing specific port. I
> think it has higher possibility that one user wants to install
> documentation/examples of *some ports but not all ports*. As a result, we
> should keep those options. At least we shall not always hide them.
> 
> If maintainers think these options are annoying, they could put them to the
> end of OPTIONS_DEFINE.

We don't disagree about  DOCS/NSL/etc options, when a ports already defines
other options. The question is should these options be in OPTIONS_DEFINE
if they are the only options provided by the port (read: allow option dialog
to pop up with trivial option set for virtually every port)?

Max
 
> On Thu, Mar 28, 2013 at 10:57 AM, Eitan Adler <eadler at freebsd.org> wrote:
> 
> > On 27 March 2013 22:53, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> > > On Mon, Mar 25, 2013 at 01:59:18PM +0000, Max Brazhnikov wrote:
> > >> New Revision: 315222
> > >> URL: http://svnweb.freebsd.org/changeset/ports/315222
> > >>
> > >> - Remove OPTIONS_DEFINE, if it contains only global options
> > >
> > > Can you elaborate on this one?  Given that there is no clear policy,
> > > personally I've been always including OPTIONS_DEFINE, even if just for,
> > say,
> > > DOCS.
> >
> > Options such as IPV6, DOCS, EXAMPLES, and NLS are generally set
> > globally (e.g., OPTIONS_UNSET= NLS) and not per port.  As such, it can
> > reduce user annoyance if the dialog box is not shown for such options.
> >
> >
> >
> > --
> > Eitan Adler
> > Source, Ports, Doc committer
> > Bugmeister, Ports Security teams
> >