svn commit: r302285 - in head: audio/gmpc-mserver multimedia/xbmc

Doug Barton dougb at FreeBSD.org
Fri Aug 10 05:12:37 UTC 2012


On 08/09/2012 10:02 PM, Eitan Adler wrote:
> On 8 August 2012 09:46, Doug Barton <dougb at freebsd.org> wrote:
> 
>> Short answer: Always do related changes together in the same commit.
> 
> I am fine with doing the initial update followed by the chase commit.

You seem to be contradicting my suggestion without providing any
rationale for your position. The whole point of using a CVS that does
atomic changesets is to do the changes atomically so that you can take
advantage of the feature.

> I agree that the entire chase commit should be done at once. This
> makes it easier to revert commits (and use mergeinfo in the
> theoretical future you mention).

Doing the commits separately does not make it easier to revert the part
of the commit that updates the port. If you believe it does, please
demonstrate.

Absent any actual reason to do the commits separately, they should be
done together.

Doug



More information about the svn-ports-head mailing list