svn commit: r566508 - in head: Mk/Uses devel/qt5-core devel/qt5/files

Adriaan de Groot adridg at freebsd.org
Tue Mar 16 19:59:40 UTC 2021


On Tuesday, 16 March 2021 03:19:09 CET Alexey Dokuchaev wrote:
> On Thu, Feb 25, 2021 at 09:35:13AM +0000, Alexey Dokuchaev wrote:
> > On Thu, Feb 25, 2021 at 10:18:04AM +0100, Mathieu Arnold wrote:
> > > On Wed, Feb 24, 2021 at 08:45:14PM +0000, Adriaan de Groot wrote:
> > > > -	@${REINPLACE_CMD} 's/\t//g' ${PKGINSTALL} ${PKGDEINSTALL}
> > > > +	# Drop all leading spaces in the script, to minify
> > > > +	@${REINPLACE_CMD} 's/^  *//' ${PKGINSTALL} ${PKGDEINSTALL}
> > > 
> > > [[:space:]] works with all versions.
> > 
> > Yes please.  Not just it's more robust, it also expresses the intention
> > better, as we probably want to trim *any* unnecessary whitespace, not
> > some particular character.
> 
> So, anything prevents us from going the [[:blank:]] way?

So which is it, [[:space:]] or [[:blank:]] ? I don't have much reason to prod 
at this right now.

[ade] (a character class accepting a, d or e, obvs)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20210316/b1f9c3a3/attachment.sig>


More information about the svn-ports-all mailing list