svn commit: r559622 - head/devel/abseil

[Po-Chuan Hsieh]

On Wed, Dec 30, 2020 at 6:25 AM Yuri Victorovich <yuri at freebsd.org> wrote:

> Author: yuri
> Date: Tue Dec 29 22:25:03 2020
> New Revision: 559622
> URL: https://svnweb.freebsd.org/changeset/ports/559622
>
> Log:
>   devel/abseil: Change to C++17 to allow all dependent ports to build
>
>   PR:           250376
>   Approved by:  danfe (maintainer's timeout)
>
> Modified:
>   head/devel/abseil/Makefile
>
> Modified: head/devel/abseil/Makefile
>
> ==============================================================================
> --- head/devel/abseil/Makefile  Tue Dec 29 22:24:24 2020        (r559621)
> +++ head/devel/abseil/Makefile  Tue Dec 29 22:25:03 2020        (r559622)
> @@ -3,6 +3,7 @@
>
>  PORTNAME=      abseil
>  PORTVERSION=   20200923.2
> +PORTREVISION=  1
>  CATEGORIES=    devel
>
>  MAINTAINER=    danfe at FreeBSD.org
> @@ -14,6 +15,7 @@ USES=         cmake compiler:c++11-lang
>

If you build this port with c++17, shouldn't this be changed to c++17-lang?


>  USE_GITHUB=    yes
>  GH_PROJECT=    ${PORTNAME}-cpp
>
> -CMAKE_ARGS=    -DBUILD_SHARED_LIBS:BOOL=ON
> +CMAKE_ARGS=    -DBUILD_SHARED_LIBS:BOOL=ON \
> +               -DCMAKE_CXX_STANDARD=17 # force the same highest C++
> standard because of ABI differences: see
> https://github.com/abseil/abseil-cpp/issues/819
>
>  .include <bsd.port.mk>
> _______________________________________________
> svn-ports-all at freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/svn-ports-all
> To unsubscribe, send any mail to "svn-ports-all-unsubscribe at freebsd.org"
>