svn commit: r553559 - in head/x11: . tilix

[myfreeweb]

On October 28, 2020 8:35:29 PM UTC, "Romain Tartière" <romain at blogreen.org> wrote:
>On Wed, Oct 28, 2020 at 09:00:39PM +0100, Jan Beich wrote:
>> Romain Tartière <romain at FreeBSD.org> writes:
>> 
>> > +PATCH_DIST_STRIP=-p1
>> > +PATCH_SITES=	https://patch-diff.githubusercontent.com/raw/gnunn1/tilix/pull/
>> > +PATCHFILES=	1733.diff
>> 
>> pull/1234.diff is a moving target. Better use commit hashes e.g.,
>> 
>> PATCH_SITES=	https://github.com/${GH_ACCOUNT}/${GH_PROJECT}/commit/
>> PATCHFILES+=	ce11b0bd936f.patch:-p1 # https://github.com/gnunn1/tilix/pull/1733
>
>Good catch, this indeed makes sense!
>
>> > +BUILD_DEPENDS=	ldc2:lang/ldc \
>> > +		po4a-translate:textproc/po4a \
>> > +		${LOCALBASE}/libdata/pkgconfig/vted-3.pc:x11-toolkits/gtkd
>> 
>> Why not use shared libs like Alpine, Arch, Debian, Fedora, Void?
>> See https://github.com/DankBSD/ports/commit/2b892e4ea4aa
>
>Oh, I was not aware of this effort :-( !  I hapenned to find out some
>old WIP ports in my local ports directory, and saw that I could get
>everything to compile, so as these pieces where not in the FreeBSD ports
>tree I though it was worth it to push them…
>
>Building shared libs seems to require quite a lot of extra work but the
>author of these ports seems to have done all this.  I added him in Cc
>(hey Greg!).  Is there a reason for your ports x11-toolkits/gtkd-3 and
>x11/tilix _not_ being in the "official" FreeBSD ports tree? 

Haven't submitted them because I was waiting on the LDC port update landing, which I think did happen recently, but now that I'm working on other stuff and I don't use Tilix currently and I abandoned my own gtkd-based project, this was not a priority for me.

> Do you have
>something to share regarding this point Jan made?  Should we not
>better integrate _your_ ports in the FreeBSD ports tree and replace what
>I just committed?  Would you be interested in being the maintainer of
>these ports?

Well, replacing the whole thing (with descriptions etc) seems like too much, just take the important part that makes the libs shared.

I'm undecided/neutral on maintaining these – they shouldn't be a burden but I don't actively use them anymore. If you actively use Tilix, you might be a better maintainer of it :)