svn commit: r552869 - in head/www: . unit-python

[Li-Wen Hsu]

On Mon, Oct 26, 2020 at 8:01 PM Mathieu Arnold <mat at freebsd.org> wrote:
>
> On Wed, Oct 21, 2020 at 03:54:22PM +0000, Sergey A. Osokin wrote:
> > Author: osa
> > Date: Wed Oct 21 15:54:22 2020
> > New Revision: 552869
> > URL: https://svnweb.freebsd.org/changeset/ports/552869
> >
> > Log:
> >   Repo-copy www/py-unit to www/unit-python to be more consistent
> >   with the naming convention.
> >   Update www/unit-python to build with new name.
> >   Disconnect www/py-unit from the build.
> >
> > Added:
> >   head/www/unit-python/
> >      - copied from r536987, head/www/py-unit/
> > Modified:
> >   head/www/Makefile
> >   head/www/unit-python/Makefile
> >
> > Modified: head/www/Makefile
> > ==============================================================================
> > --- head/www/Makefile Wed Oct 21 15:43:44 2020        (r552868)
> > +++ head/www/Makefile Wed Oct 21 15:54:22 2020        (r552869)
> > @@ -1722,7 +1722,6 @@
> >      SUBDIR += py-turbogears2
> >      SUBDIR += py-tvdb_api
> >      SUBDIR += py-txrequests
> > -    SUBDIR += py-unit
> >      SUBDIR += py-urlgrabber
> >      SUBDIR += py-urlman
> >      SUBDIR += py-urlobject
> > @@ -2257,6 +2256,7 @@
> >      SUBDIR += unit
> >      SUBDIR += unit-perl
> >      SUBDIR += unit-php
> > +    SUBDIR += unit-python
> >      SUBDIR += unit-ruby
> >      SUBDIR += uwebsockets
> >      SUBDIR += uwsgi
> >
> > Modified: head/www/unit-python/Makefile
> > ==============================================================================
> > --- head/www/py-unit/Makefile Fri May 29 18:36:38 2020        (r536987)
> > +++ head/www/unit-python/Makefile     Wed Oct 21 15:54:22 2020        (r552869)
> > @@ -1,7 +1,7 @@
> >  # Created by: Li-Wen Hsu <lwhsu at FreeBSD.org>
> >  # $FreeBSD$
> >
> > -PKGNAMEPREFIX=       ${PYTHON_PKGNAMEPREFIX}
> > +PKGNAMESUFFIX=       -python${PYTHON_SUFFIX}
>
> This is wrong, the port should be called py-unit-python, and you should
> be using:
>
> PKGNAMEPREFIX=  ${PYTHON_PKGNAMEPREFIX}
> PKGNAMESUFFIX=  -python

I think what Sergey wants here is to maintain the common unit- prefix
for easier to identify. This port doesn't install anything in
PYTHON_SITELIBDIR but a .so in its module directory. I think we can
relax in this case.  BTW, maybe USE_PYTHON=optsuffix is useful here.

Best,
Li-Wen