svn commit: r552232 - head/devel/git

[Mathieu Arnold]

On Tue, Oct 13, 2020 at 11:32:27AM +0000, Renato Botelho wrote:
> Author: garga
> Date: Tue Oct 13 11:32:26 2020
> New Revision: 552232
> URL: https://svnweb.freebsd.org/changeset/ports/552232
> 
> Log:
>   Simplify logic to define COMMENT
>   
>   Submitted by:	bapt
> 
> Modified:
>   head/devel/git/Makefile
> 
> Modified: head/devel/git/Makefile
> ==============================================================================
> --- head/devel/git/Makefile	Tue Oct 13 11:30:50 2020	(r552231)
> +++ head/devel/git/Makefile	Tue Oct 13 11:32:26 2020	(r552232)
> @@ -12,12 +12,11 @@ EXTRACT_ONLY=	${DISTNAME}${EXTRACT_SUFX} \
>  		${PORTNAME}-manpages-${DISTVERSION}${EXTRACT_SUFX}
>  
>  MAINTAINER=	garga at FreeBSD.org
> -.if ${FLAVOR:Udefault} == default
>  COMMENT=	Distributed source code management tool
> -.elif ${FLAVOR:U} == gui
> -COMMENT=	Distributed source code management tool (GUI enabled flavor)
> +.if ${FLAVOR:U} == gui
> +COMMENT+=	(GUI enabled flavor)
>  .elif ${FLAVOR:U} == lite
> -COMMENT=	Distributed source code management tool (lite flavor)
> +COMMENT+=	(lite flavor)
>  .endif

If one really wanted to make it clear and simple, one could even write:

COMMENT=	Distributed source code management tool ${COMMENT_${FLAVOR}}
COMMENT_gui=	(GUI enabled flavor)
COMMENT_lite=	(lite flavor)

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20201014/2e7713f9/attachment.sig>